Cleaned Up API, Added Command Line App #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…han raw byte arrays
…siren access into SirenOfShameDevice.java (like SirenOfShameDevice.cs)
…le task so we can build jars.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know if you'll want these changes, but I've finally gotten back to this project and the excellent thing you started. I've centralized all logic for controlling the siren into a SirenOfShameDevice class that mirrors the C# one. I added in a pretty functional command line app (Program.java). I've added/implemented a few of the commands that you proved out like reading device info (current pattern playing, duration remaining) and reading both led and audio patterns and displaying them all, and setting led's manually.
I'm going to work on packaging and deploying next, so I thought I'd do this PR now. Among other things I'd like to replace "hanik" in the namespace with automated architecture. I hope you don't mind. I'll give you full credit in the readme, on twitter, or wherever else I can think to do so. I hope that's ok, I can't tell you how much I appreciate your help with this.