Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PRE_COMMIT_SECTOR_BATCH_MAX_SIZE and other gas-limited parameters #1268

Open
Tracked by #1274
jennijuju opened this issue Apr 3, 2023 · 1 comment · May be fixed by #1586
Open
Tracked by #1274

Remove PRE_COMMIT_SECTOR_BATCH_MAX_SIZE and other gas-limited parameters #1268

jennijuju opened this issue Apr 3, 2023 · 1 comment · May be fixed by #1586
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
Profiling, harden...

Comments

@jennijuju
Copy link
Member

related to filecoin-project/lotus#10612

tl'dr: with FVM the execution gas are now properly accounted, and if the FVM gas accounting changes, the max value of how many msg can fit in one block may change.

Its better to remove thee limit from actors and have clients to perform gas estimation and properly aggregate sectors for users accordingly
@jennijuju jennijuju added the enhancement New feature or request label Apr 3, 2023
@jennijuju jennijuju added this to the 2023 Actor 🧹 milestone Apr 3, 2023
@anorth
Copy link
Member

anorth commented Apr 3, 2023 •
edited
Loading

There are other parameters that can be removed too, e.g. around Window PoSt.

  • DECLARATIONS_MAX

@ZenGround0 ZenGround0 added the good first issue Good for newcomers label May 9, 2023
@jennijuju jennijuju mentioned this issue May 19, 2023
Closed
@anorth anorth changed the title Remove MAX_AGGREGATED_SECTORS and PRE_COMMIT_SECTOR_BATCH_MAX_SIZE Remove PRE_COMMIT_SECTOR_BATCH_MAX_SIZE and other gas-limited parameters May 27, 2024
This was referenced May 27, 2024
Closed
Closed
@rjan90 rjan90 added this to FilOz Sep 17, 2024
@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Sep 17, 2024
@rjan90 rjan90 moved this from 📌 Triage to 🐱 Todo in FilOz Sep 17, 2024
@Caruso33 Caruso33 mentioned this issue Oct 11, 2024
Open
@kamuik16 kamuik16 linked a pull request Oct 22, 2024 that will close this issue
Open
@rjan90 rjan90 moved this from 🐱 Todo to ⌨️ In Progress in FilOz Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
FilOz
Status: ⌨️ In Progress
Milestone
Profiling, hardening and cleanups'23
3 participants
@anorth @ZenGround0 @jennijuju