Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove async handling of terminated deals from market actor #1388

Open
alexytsu opened this issue Aug 30, 2023 · 2 comments
Open

Remove async handling of terminated deals from market actor #1388

alexytsu opened this issue Aug 30, 2023 · 2 comments
Assignees

Comments

@alexytsu
Copy link
Contributor

This can only be done after synchronous terminations has gone live.

When that code goes live, it must still handle any deals scheduled for cleanup that haven't been processed by cron yet.

After synchronous terminations is live, it should be impossible to encounter terminated sectors asynchronously. All code paths other than on_miner_sector_terminate should not handle terminations (and error if marked-for-termination) sectors are encountered.

@alexytsu
Copy link
Contributor Author

Must be done after #1377 goes live and after all marked-for-termination deals are cleared from chain state.

@ZenGround0
Copy link
Contributor

Relevant section of the code: https://github.com/filecoin-project/builtin-actors/blob/master/actors/market/src/lib.rs#L952-L975

This should be good after DEAL_UPDATES_INTERVAL or 30 days from the last upgrade. So this should be good for either of the next upgrades. Worth sanity checking the DOBE queue to check that we don't see any async terminations scheduled before we do this.

@ZenGround0 ZenGround0 moved this from 📌 Triage to 🐱Todo in FilOz Jun 4, 2024
@ZenGround0 ZenGround0 added the P2 label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🐱 Todo
Development

No branches or pull requests

2 participants