Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check owner & worker same as msg sender upon creating miners? #1479

Open
jinqiao0423 opened this issue Nov 9, 2023 · 0 comments
Open

Check owner & worker same as msg sender upon creating miners? #1479

jinqiao0423 opened this issue Nov 9, 2023 · 0 comments

Comments

@jinqiao0423
Copy link

jinqiao0423 commented Nov 9, 2023

Currently owner & worker can be set to whichever address upon creating miners, with no checks. This means that one create as many miners as he/she would like for any addresses.

This can bring possible harm i.e. possiblity mistaking real & fake miners / annoying when browsing owner info on explorer and possible token loss.

On the other hand this brings logic inconsistency comparing to owner changing: permission from new owner is needed upon owner changing, while permission from new owner is not needed upon miner creation.

Suggestion: checks owner & worker exactly the same as msg sender upon creating miners.

@jinqiao0423 jinqiao0423 changed the title Check upon creating miners? Check owner & worker same as msg sender upon creating miners? Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant