Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deal_ids field from SectorOnChainInfo #1497

Open
anorth opened this issue Jan 12, 2024 · 2 comments
Open

Remove deal_ids field from SectorOnChainInfo #1497

anorth opened this issue Jan 12, 2024 · 2 comments
Labels

Comments

@anorth
Copy link
Member

anorth commented Jan 12, 2024

From FIP-0076, the sector deal_ids field is deprecated. We left it in place to preserve the data in all the existing sectors, where it might be useful for some disaster recovery in case the migration is broken, etc. But once the network is operating smoothly without using it, we can delete the field next time we migrate sector info.

@kamuik16
Copy link
Contributor

kamuik16 commented Aug 7, 2024

Hey @anorth @rjan90
I can work on this if you guys have decided to remove the field. Lmk.

@Stebalien
Copy link
Member

we can delete the field next time we migrate sector info.

As far as I know, we have no FIPs planned that need to re-write the sector infos. We won't remove this field until then as that would lead to a lot of unnecessary state churn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🐱 Todo
Development

No branches or pull requests

3 participants