Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove InternalSectorSetupForPreseal #1556

Open
ZenGround0 opened this issue Jun 23, 2024 · 2 comments
Open

Remove InternalSectorSetupForPreseal #1556

ZenGround0 opened this issue Jun 23, 2024 · 2 comments

Comments

@ZenGround0
Copy link
Contributor

Because of time pressure for nv23 we were forced into a corner and could not completely remove all traces of FIP 0084. We had to keep around a version of CSPV renamed to InteranlSectorSetupForPreseal: #1553

This whole PR should be reverted. We should not be shipping this endpoint to the miner actor in the production bundle.

The reason we need it is that lotus-seed, which is used in devnets, butterfly and rarely calibration reset, needs a way to mock out miner state. The correct way to do this is to use a sector proving method, however this requires either sealed sectors with proofs which is not feasible for large networks or the ability to mock out syscalls.

The correct approach is to mock out syscalls. However this is technically challenging since the FVM was introduced. When @aarshkshah1992 and I looked at this last week it appears that this will require significant engineering work on the FVM and its ffi to the lotus node.

@ZenGround0
Copy link
Contributor Author

An idea from @Stebalien -- there exists a testing bundle that we use to fake out proofs in lotus tests. We could just use this in lotus-seed.

@aarshkshah1992
Copy link
Contributor

@ZenGround0 To be clear, lotus-seed only creates the genesis file. The execution happens when we start lotus daemon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🥞 Todo
Development

No branches or pull requests

2 participants