Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep GPBFT disabled until the node actually starts participating. #650

Open
Stebalien opened this issue Sep 22, 2024 · 4 comments
Open

Keep GPBFT disabled until the node actually starts participating. #650

Stebalien opened this issue Sep 22, 2024 · 4 comments

Comments

@Stebalien
Copy link
Member

Until some storageminer process calls F3Participate, we should passively follow F3 via the finality certificate exchange instead of via pubsub to avoid wasting bandwidth. This way:

  1. Pure clients can save a lot of bandwidth.
  2. SPs can save bandwidth by delegating all F3 operations to a single client.
@masih
Copy link
Member

masih commented Oct 8, 2024

This would probably touch some of #588? Would be nice to knock that one out too.

@Stebalien
Copy link
Member Author

It should be mostly orthogonal, but I agree.

@Stebalien
Copy link
Member Author

Two options:

  1. Abstract over this in lotus and don't start the inner F3 module until we need it. That'll lead to a cleaner solution in this repo, but we'll also have some duplicate setup code (need a certstore, certserve, certsub, etc.).
  2. Change F3.MessagesToSign to something like F3.Participate(), lazily starting the runner on-demand. Honestly, we don't really need a way to stop participating.

Personally, I'm leaning towards option 2. It's a bit of work in this repo, but not much.

@masih
Copy link
Member

masih commented Oct 8, 2024

Option 2 sgtm too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

4 participants