Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag metrics with a network name/network tag #12715

Closed
Kubuxu opened this issue Nov 22, 2024 · 1 comment · Fixed by #12733
Closed

Tag metrics with a network name/network tag #12715

Kubuxu opened this issue Nov 22, 2024 · 1 comment · Fixed by #12733
Assignees
Labels
good first issue Good for newcomers kind/feature Kind: Feature

Comments

@Kubuxu
Copy link
Contributor

Kubuxu commented Nov 22, 2024

Tag exported metrics with a network dependent tag such that in metric collection we don't have to create host -> network mapping.

@rvagg
Copy link
Member

rvagg commented Dec 18, 2024

Many of the metrics were completed in #12733

Unfortunately we have a whole lot of context.Background() and context.TODO() that are stopping us getting at some important ones and they're not so simple to solve.

In #12793 I started looking at getting contexts wired through to many of these places, or adding the tag to new contexts where it doesn't make sense, but it's tedious work and there's a lot more to do and a lot of localised reasoning that needs to be done to understand if a context should be detached or not.

So #12733's CHANGELOG entry said there would be follow-up work, this issue will remain as a tracker for that work.

@github-project-automation github-project-automation bot moved this from 📌 Triage to 🎉 Done in FilOz Dec 18, 2024
@rjan90 rjan90 moved this from 🎉 Done to ☑️ Done (Archive) in FilOz Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/feature Kind: Feature
Projects
Status: ☑️ Done (Archive)
Development

Successfully merging a pull request may close this issue.

3 participants