-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Cannot import files outside of module root directory" #485
Comments
I find it suspicious that |
Could be! But I don't think so necessarily https://stackoverflow.com/questions/21194530/what-does-mean-when-prepended-to-a-file-path |
Great find! Another interesting fact: The module toot directory contains I suspect Deno uses a process for converting paths to strings on Windows that is different from Zinnia's. @juliangruber What is the impact of this issue? How many users are affected? |
I think this may be fixed by filecoin-station/core#345. Let's see if the problem persists after people update their Station versions to apply that patch. |
yeah! I'm releasing the changes atm, to validate this |
Released in https://github.com/filecoin-station/desktop/releases/tag/v1.3.8, asked user for confirmation |
Let's reopen if the issue comes back |
This issue came back. This time it was also captured with Spark. The paths all look correct. I assume this is a cross platform path handling issue.
I formatted the logs for better readability.
|
I cannot reproduce this on my Windows 11 Pro laptop |
I have asked the issue reporter for additional details on their setup. This bug is preventing them from using Zinnia. |
Can you create a user on your Windows laptop with a long username and/or a username containing non-ASCII characters? Would that reproduce the problem?
Yeah, I am thinking the same. Windows have several different ways how to encode filesystem paths. Preserving backwards compatibility all the way back to MS-DOS and 8.3 filename format comes with costs. |
From the original error reporting I can tell that the username in question consists of
😱 |
@juliangruber what's the severity/priority of this issue? Should we prioritise it for the next milestone? |
We have only heard about this from one user. They are not able to participate at all because of this. We don't know how many blocked users we aren't aware of. I propose we as a team discuss the severity of this issue. |
It happened again, see filecoin-station/desktop#1639
|
I don't know, it was installed in the default routes, the real route is this "C:\Users", could you tell me where that route is saved? Maybe I can change it and it can be fixed |
I I have uninstalled Filecoin station New log: |
Zinniad logs from the log file attached in the comment above:
Additional material I found on the internet: https://fleexlab.blogspot.com/2016/07/what-are-those-backslash-double.html
https://users.rust-lang.org/t/understanding-windows-paths/58583/2
https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file |
I improved the log messages for this error to include additional information, I hope it will help us to understand better the problem and how to fix it. Can you please upgrade your Station Desktop to the latest versions (1.9.0) and send us the new error messages from the module log file? |
New log ver 1.9.0 |
Thank you, @nekros05. The logs confirmed my suspicion. The Windows path created from the URL of the imported module starts with |
Could you please install v2.0.1 and upload the new module logs? I reworked the module sandboxing in Zinnia. Either the problem will go away, or else I should hopefully get enough the information to fix it. |
@bajtos same error. New log: |
Cross-posting the relevant part from the module log:
@nekros05 can you please try the following steps?
@juliangruber It looks like the main module file ( https://learn.microsoft.com/en-us/windows/win32/debug/system-error-codes--0-499-
Do you have any idea why that could happen? |
Hi @bajtos , it is already working, but now there is a new problem, the window goes blank after 2-3 seconds of opening it. Version 2.0.2 |
Please open a new GitHub issue for that in the Station Desktop repo: |
The issue is still happening, see https://space-meridian.sentry.io/issues/5258168696/
|
Sentry Issue: STATION-CORE-AK4 |
This error was submitted by a user in https://filecoinproject.slack.com/archives/C03S6LXSRB8/p1707311859950409:
This is the first time I've seen that error, other installations are looking fine.
Some suspicions:
Zinnia source of error:
zinnia/runtime/module_loader.rs
Line 99 in ca764ff
Mentioned Voyager file: https://github.com/filecoin-station/voyager/blob/4f4410c36df95774e6f52cabf717c322e27e6693/main.js
The text was updated successfully, but these errors were encountered: