Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Delete icon appears disabled for image files #16715

Closed
gilnett opened this issue Jan 17, 2025 · 11 comments · Fixed by #17032
Closed

Bug: Delete icon appears disabled for image files #16715

gilnett opened this issue Jan 17, 2025 · 11 comments · Fixed by #17032
Labels
area - toolbar Features or bug reports relating to the toolbar

Comments

@gilnett
Copy link

gilnett commented Jan 17, 2025

Description

I noticed a bug in the app. When I click on an image, it doesn’t light up like it’s selected. But I can still delete it, even though it doesn’t show right away.

Image

Image

Steps To Reproduce

1.select image
2.see trash icon

Files Version

3.8.12

Windows Version

11

User ID

908173a8-ad8c-45b3-b38b-80790456963e

Log File

debug.log

@Josh65-2201
Copy link
Member

Thanks for the report.

@Josh65-2201 Josh65-2201 changed the title Bug:Issue with Selecting Images Bug: Toolbar delete icon doesn't show as available when selecting a file/folder Jan 18, 2025
@Josh65-2201 Josh65-2201 added the area - toolbar Features or bug reports relating to the toolbar label Jan 18, 2025
@yaira2
Copy link
Member

yaira2 commented Jan 18, 2025

When I click on an image, it doesn’t light up like it’s selected

Can you clarify what you mean by lighting up?

@yaira2 yaira2 added the needs - additional info Needs more information from the reporter label Jan 18, 2025
@Josh65-2201
Copy link
Member

The toolbar delete icon doesn't look like it a usable option.
Shows for images as
Image

Should be
Image

@yaira2
Copy link
Member

yaira2 commented Jan 19, 2025

Is this only for images?

@Josh65-2201
Copy link
Member

It is for me.

@yaira2 yaira2 changed the title Bug: Toolbar delete icon doesn't show as available when selecting a file/folder Bug: Delete icon appears disabled for image files Jan 19, 2025
@yaira2 yaira2 moved this from 🆕 New to 🔖 Ready to build in Files task board Jan 19, 2025
@yaira2 yaira2 removed the needs - additional info Needs more information from the reporter label Jan 19, 2025
@Lamparter
Copy link
Contributor

Lamparter commented Jan 19, 2025

The button still works even though it appears disabled which is incredibly strange

I've also noticed that after clicking it a few times it returns to the original style.

@gilnett
Copy link
Author

gilnett commented Jan 19, 2025

only image for me

@Josh65-2201
Copy link
Member

I have found that it also happening with .ps1 and .bat files too

@Lamparter
Copy link
Contributor

Yep, can reproduce that

@jpozo20
Copy link

jpozo20 commented Apr 8, 2025

I was having a look at this bug and I think with this change it is solved.
Seems to me it was a race condition with the IsEnabled property of some icons. Though I couldn't exactly find where they're being enabled since it's not in the xaml of the Toolbar.

@yaira2 yaira2 moved this from 🔖 Ready to build to 🏗 In progress in Files task board Apr 8, 2025
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Files task board Apr 9, 2025
@yaira2
Copy link
Member

yaira2 commented Apr 9, 2025

This issue should be resolved with the next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area - toolbar Features or bug reports relating to the toolbar
Projects
Status: Done
5 participants