Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File preview is broken in debug mode #4206

Closed
d2dyno1 opened this issue Mar 21, 2021 · 30 comments
Closed

File preview is broken in debug mode #4206

d2dyno1 opened this issue Mar 21, 2021 · 30 comments
Labels
bug Something isn't working 👀 needs - additional info Needs more information from the reporter

Comments

@d2dyno1
Copy link
Member

d2dyno1 commented Mar 21, 2021

Explain the bug
The details of file preview are not shown, only folder previews are displayed correctly. Additionally the UI of sound and video files is broken

Screenshots
Working (old):
image

Broken (new):
image

@d2dyno1 d2dyno1 added the bug Something isn't working 👀 label Mar 21, 2021
@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 21, 2021

Fyi @winston-de

@winston-de
Copy link
Contributor

@d2dyno1 Thanks for reporting this.
Are you referring to the messed up icons in the player, or the details not showing?

@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 21, 2021

@winston-de both.

@winston-de
Copy link
Contributor

@d2dyno1
The messed up icons are an issue with WinUI 2.6, not with Files.
image

As for the details not showing, I can't reproduce the issue, do you have any other information or a specific file I could test with?
image

@yaira2
Copy link
Member

yaira2 commented Mar 21, 2021

@d2dyno1 I can't reproduce this issue in v1.4.46.

@yaira2 yaira2 closed this as completed Mar 21, 2021
@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 21, 2021

@yaira2
Copy link
Member

yaira2 commented Mar 21, 2021

@d2dyno1 What version of Files do you have?

@yaira2 yaira2 reopened this Mar 21, 2021
@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 21, 2021

That was the latest commit where the Interaction was removed on

@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 21, 2021

@yaichenbaum @winston-de Update: This was not caused by #4189. I've cloned the commit before that, and the issue was still present

@d2dyno1 d2dyno1 changed the title Broken video and sound preview File preview is broken Mar 21, 2021
@winston-de
Copy link
Contributor

@d2dyno1 I'm testing on the latest version of main, and the file works as expected.
image

@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 21, 2021

@winston-de "Works on my machine" 😂

@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 21, 2021

Yo, even the icons are aligned!

@winston-de
Copy link
Contributor

@d2dyno1 Wait, that was the wrong screenshot

image

@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 21, 2021

What? Then why were they aligned in the previous one? 😆

@winston-de
Copy link
Contributor

@yaichenbaum On the subject, would it be alright if I made the logger in App.xaml.cs a public property, and used it to log errors caught when loading the preview and/or details? This would make it much easier to debug issues such as this.

@winston-de
Copy link
Contributor

@d2dyno1 I accidently tested on the release version instead of my local dev build.

@winston-de
Copy link
Contributor

winston-de commented Mar 21, 2021

@d2dyno1 I know it's asking a lot, but could please clone this branch, do the same thing with it, then upload the log files afterwards?
This will help me debug the issue.

@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 21, 2021

Sure, but I'll do it tomorrow

@yaira2
Copy link
Member

yaira2 commented Mar 21, 2021

Yo, even the icons are aligned!

The icon alignment is an issue with WinUI.

@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 22, 2021

@winston-de I've just tested your branch and it still doesn't work :(

@winston-de
Copy link
Contributor

winston-de commented Mar 22, 2021

@d2dyno1 Yeah I didn't expect it to it's just some debugging stuff, could you upload the log file please?

@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 22, 2021

@winston-de Here it is: debug.txt

@winston-de
Copy link
Contributor

@d2dyno1 Thanks. This is very interesting.

2021-03-22 19:04:50.2768|ERROR|Files.App|System.Exception: A security problem occurred. (Exception from HRESULT: 0x800C000E)
   at Files.ViewModels.Properties.FileProperty.RetrieveAndInitializePropertiesAsync(StorageFile file, String path)
   at Files.ViewModels.Previews.BasePreviewModel.GetSystemFileProperties()
   at Files.ViewModels.Previews.BasePreviewModel.LoadAsync()|System.Exception: A security problem occurred. (Exception from HRESULT: 0x800C000E)
   at Files.ViewModels.Properties.FileProperty.RetrieveAndInitializePropertiesAsync(StorageFile file, String path)
   at Files.ViewModels.Previews.BasePreviewModel.GetSystemFileProperties()
   at Files.ViewModels.Previews.BasePreviewModel.LoadAsync()

I have never seen this before, but I will see if I can fix it.

@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 22, 2021

Could it be because I'm running it in debug mode?

@winston-de
Copy link
Contributor

@d2dyno1 This doesn't occur with the store version, correct?

@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 22, 2021

@d2dyno1 This doesn't occur with the store version, correct?

It does not. The store version works as intended.

@winston-de
Copy link
Contributor

@d2dyno1 what build are you on?

@d2dyno1
Copy link
Member Author

d2dyno1 commented Mar 22, 2021

(From MS Store)
image

@winston-de
Copy link
Contributor

@d2dyno1 there dont seem to be any changes since 1.3 that changed that part of the code, so yes, I think this is an issue that occurs in debug mode. If you see this occur in a release build, please let me know.

@lukeblevins lukeblevins changed the title File preview is broken File preview is broken in debug mode Apr 24, 2021
@yaira2
Copy link
Member

yaira2 commented Apr 27, 2021

@duke7553 Is this specific to debug mode?
@d2dyno1 Can you check if this is still an issue with the latest in main?

@yaira2 yaira2 added the needs - additional info Needs more information from the reporter label Apr 27, 2021
@yaira2 yaira2 closed this as completed May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 👀 needs - additional info Needs more information from the reporter
Projects
None yet
Development

No branches or pull requests

3 participants