Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title and aria-* options to ActionButtonItem #30

Open
TimmFitschen opened this issue Sep 5, 2023 · 1 comment
Open

Add title and aria-* options to ActionButtonItem #30

TimmFitschen opened this issue Sep 5, 2023 · 1 comment

Comments

@TimmFitschen
Copy link
Contributor

TimmFitschen commented Sep 5, 2023

Is your feature request related to a problem? Please describe.

Currently, actionButtons are not following modern best practices for a11y (accessibility), especially WAI-ARIA out of the box and do not allow to specify the title or aria attributes manually.

Describe the solution you'd like

Add title the option explicitly and allow aria-* attributes to be passed on to the button element.

<Dropzone 
  actionButtons={{
    uploadButton: {
      ariaLabel: "Click here to upload the selected files."
      title="Click here to upload the selected files."
    }
  }}/> 

Describe alternatives you've considered

Providing good defaults first and add the customization later - however, this is much more effort and defaults should be chosen carefully. So I think customization first and defaults later is better in this case.

@TimmFitschen
Copy link
Contributor Author

I could provide an implementation if you want, @JinSSJ3 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant