Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

alps.title element & descriptor.def attribute are not converted #109

Closed
NaokiTsuchiya opened this issue May 28, 2021 · 3 comments · Fixed by #112
Closed

alps.title element & descriptor.def attribute are not converted #109

NaokiTsuchiya opened this issue May 28, 2021 · 3 comments · Fixed by #112
Labels
bug Something isn't working

Comments

@NaokiTsuchiya
Copy link

Describe the bug

Try to convert ALPS using https://eiger.apicatalog.com/, alps.title element & descriptor.def attribute have not been converted.

To Reproduce

Input this xml.

<?xml version="1.0" encoding="UTF-8"?>
<alps version="1.0"
      xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
      xsi:noNamespaceSchemaLocation="https://alps-io.github.io/schemas/alps.xsd">
    <title>MyAlps</title>
    <descriptor id="id" def="https://schema.org/identifier"/>
</alps>

Output this json.

{
    "alps": {
        "version": "1.0",
        "descriptor": {
            "id": "id",
            "type": "semantic"
        }
    }
}

Expected behavior

Output this json.

{
    "alps": {
        "version": "1.0",
        "title": "MyAlps",
        "descriptor": {
            "id": "id",
            "type": "semantic",
            "def": "https://schema.org/identifier"
        }
    }
}

Additional context

@filip26 filip26 added the bug Something isn't working label May 28, 2021
@filip26
Copy link
Owner

filip26 commented May 28, 2021

Title fix is depends on alps-io/spec#113 resolution.

@filip26 filip26 linked a pull request May 29, 2021 that will close this issue
@filip26
Copy link
Owner

filip26 commented May 29, 2021

A title must be an element for now. e.g.

<alps>
   <title>doc title </title>
   <descriptor>
       <title>descriptor title</title>
   </descriptor>
   <link>
       <title>descriptor title</title>
   </link>   
</alps>

filip26 added a commit that referenced this issue May 29, 2021
@filip26
Copy link
Owner

filip26 commented May 29, 2021

Fixed in alps-unified branch and online.

@filip26 filip26 closed this as completed May 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants