Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODOs #1

Open
30 of 32 tasks
filipdutescu opened this issue Oct 11, 2019 · 0 comments
Open
30 of 32 tasks

TODOs #1

filipdutescu opened this issue Oct 11, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@filipdutescu
Copy link
Owner

filipdutescu commented Oct 11, 2019

To be implemented:

  • Change date formats to use the C++20 <chrono> way and provide "legacy" support

In progress:

Implemented:

  • See whether or not it makes sense to keep rvalue overloads of methods
  • On strrchr call, check if return value is 0/nullptr and handle it
  • Check return by const values to actually make sense
  • Change inlines from declaration to definitions as per guideline
  • OS detection with predefined macros
  • Thread-safety for sblogger::FileLogger and sblogger::StreamLogger
  • Add a Wiki
  • Continue updating README.md (currently: add notes for new trace, debug etc. methods; defining default log level section etc)
  • Test on Linux
  • Fix ctors of sblogger::DailyLogger (remove ceiling)
  • sblogger::FileLogger add getter for m_FilePath (with recreating file stream on set)
  • Daily created file logs (changing the log file every day at a specified hour)
  • Fix bug crashing when non-date placeholders not changed before replacing dates
  • On error logging add file and line macros for more insight into the error
  • Add colors for stream logging
  • More complex formats (ex.: log date as yyyy-MM-dd)
  • Change std::string to std::string_view wherever sensible
  • Fix std::string_view in sblogger::Logger constructor for legacy (pre C++17)
  • Replace usage of <regex> methods where sensible, in favour of <string>/pcre
  • Different log types/levels for sblogger::Logger::Write & sblogger::Logger::WriteLine (ex.: Error, Log, Debug, Trace etc.)
  • Fix __cplusplus if statements & sblogger::FileLogger::Flush to flush only if stream is open
  • Added Legacy support for pre C++17 compilers
  • Fix bug in std::StreamLogger constructor, that makes std::StreamLogger("format") access the wrong constructor, instead of the one with mandatory format and optional autoflush
  • Change file path regex to using <filesystem>
  • Log formats
  • Fix regex ending
  • Clear file log with FileLogger (sblogger::FileLogger::ClearLogs)
  • Regex validation of file path
  • Custom exception for the library

Maybe?

  • Fix replaceDateFormats(std::string&) maybe memory problem

Abandoned:

  • Logger factory
@filipdutescu filipdutescu added the enhancement New feature or request label Oct 11, 2019
@filipdutescu filipdutescu self-assigned this Oct 11, 2019
@filipdutescu filipdutescu pinned this issue Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant