Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Option<bool> in favour of bool #23

Open
filipdutescu opened this issue Apr 11, 2023 · 0 comments
Open

Remove Option<bool> in favour of bool #23

filipdutescu opened this issue Apr 11, 2023 · 0 comments
Assignees
@filipdutescu
Labels
bug Something isn't working
Milestone
1.0

Comments

@filipdutescu
Copy link
Owner

filipdutescu commented Apr 11, 2023 •
edited
Loading

Summary

There are various modifiers, such as light, which instead of being bool are Option<bool>. This is unnecessary, since a boolean value already contains all needed information. Remove Option<T> from the properties that can be set with defaults which lead to no extra classes added (align for buttons or breadcrumb).
@filipdutescu filipdutescu added the bug Something isn't working label Apr 11, 2023
@filipdutescu filipdutescu added this to the 1.0 milestone Apr 11, 2023
@filipdutescu filipdutescu self-assigned this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@filipdutescu filipdutescu

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@filipdutescu