Skip to content

Commit 725a33a

Browse files
fix(remote-config): js interop types (#17806)
* fix(remote-config): js interop types * fix: more js interop types * fix: invalid interop type * fix: getValue to dart * fix: lint
1 parent ec5813a commit 725a33a

File tree

2 files changed

+7
-26
lines changed

2 files changed

+7
-26
lines changed

packages/firebase_remote_config/firebase_remote_config_web/lib/src/interop/firebase_remote_config.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ class RemoteConfig
123123
remote_config_interop.getValue(jsObject, key.toJS).asString().toDart,
124124
),
125125
getSource(
126-
remote_config_interop.getValue(jsObject, key.toJS).getSource().toDart,
126+
remote_config_interop.getValue(jsObject, key.toJS).asString().toDart,
127127
),
128128
);
129129

packages/firebase_remote_config/firebase_remote_config_web/lib/src/interop/firebase_remote_config_interop.dart

Lines changed: 6 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ external JSPromise fetchConfig(RemoteConfigJsImpl remoteConfig);
3333

3434
@JS()
3535
@staticInterop
36-
external JSAny getAll(RemoteConfigJsImpl remoteConfig);
36+
external JSObject getAll(RemoteConfigJsImpl remoteConfig);
3737

3838
@JS()
3939
@staticInterop
@@ -66,11 +66,7 @@ external JSPromise setCustomSignals(
6666
@staticInterop
6767
external void setLogLevel(RemoteConfigJsImpl remoteConfig, JSString logLevel);
6868

69-
@JS('RemoteConfig')
70-
@staticInterop
71-
abstract class RemoteConfigJsImpl {}
72-
73-
extension RemoteConfigJsImplExtension on RemoteConfigJsImpl {
69+
extension type RemoteConfigJsImpl._(JSObject _) implements JSObject {
7470
external AppJsImpl get app;
7571
external SettingsJsImpl get settings;
7672
external set settings(SettingsJsImpl value);
@@ -80,24 +76,14 @@ extension RemoteConfigJsImplExtension on RemoteConfigJsImpl {
8076
external JSString get lastFetchStatus;
8177
}
8278

83-
@JS()
84-
@staticInterop
85-
@anonymous
86-
abstract class ValueJsImpl {}
87-
88-
extension ValueJsImplExtension on ValueJsImpl {
79+
extension type ValueJsImpl._(JSObject _) implements JSObject {
8980
external JSBoolean asBoolean();
9081
external JSNumber asNumber();
9182
external JSString asString();
9283
external JSString getSource();
9384
}
9485

95-
@JS()
96-
@staticInterop
97-
@anonymous
98-
abstract class SettingsJsImpl {}
99-
100-
extension SettingsJsImplExtension on SettingsJsImpl {
86+
extension type SettingsJsImpl._(JSObject _) implements JSObject {
10187
external JSNumber get minimumFetchIntervalMillis;
10288
external set minimumFetchIntervalMillis(JSNumber value);
10389
external JSNumber get fetchTimeoutMillis;
@@ -115,18 +101,13 @@ abstract class ConfigUpdateObserver {
115101
});
116102
}
117103

118-
extension ConfigUpdateObserverJsImpl on ConfigUpdateObserver {
104+
extension type ConfigUpdateObserverJsImpl._(JSObject _) implements JSObject {
119105
external JSAny get next;
120106
external JSAny get error;
121107
external JSAny get complete;
122108
}
123109

124-
@JS()
125-
@staticInterop
126-
@anonymous
127-
abstract class ConfigUpdateJsImpl {}
128-
129-
extension ConfigUpdateJsImplExtension on ConfigUpdateJsImpl {
110+
extension type ConfigUpdateJsImpl._(JSObject _) implements JSObject {
130111
external JSSet getUpdatedKeys();
131112
}
132113

0 commit comments

Comments
 (0)