-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dev UI] Available datasets should be scoped to the target being tested #1554
Comments
#1647 is now merged. We can support data validation in the Dev UI now. genkit-tools package must be updated for this change!. See https://github.com/FirebasePrivate/genkit-ui/tree/main?tab=readme-ov-file#shipping-the-changes for details Scope:
Mock: |
What happens when we have a LOT of datasets. Will it be obvious which ones are suitable to use? Or will the user need to click through each one? Why non-blocking? Is it a matter of needing "loose" schema validation? Or another requirement? |
It will not be obvious to see which ones are suitable. Validations needs to be done on a pair of dataset and targetAction and must cover all samples in the dataset to be reliable. It is not feasible (or worth it) to do all that computation to determine suitable datasets. We can implement a mat-menu with search filter to help users narrow down to a dataset (or action). Why non-blocking: It is primarily for loose schema validation. The motivation is originally from dataset Schema validation, where a copy of the schema is stored on the dataset metadata. Loose validation helps in cases where there is drift between the dataset schema and action schema. In the run-evaluation component, there is no technical need to support non-blocking validation. But it helps to reduce user friction, (they can proceed without being forced to go back and fix all errors in their dataset) |
@shrutip90 for decision on blocking behaviour |
Overview
Currently, it's possible to create a "model" dataset, and try to evaluate a "flow" with that dataset. Fundamentally, these are incompatible and will cause an error.
User goal(s)
Help choosing relevant datasets.
Requirements
Acceptance Criteria
Designs
Inlined screenshots
Notes
After choosing a flow, model datasets are still available in the drop down:
Running the evaluation shows success, but it is really a failure:
The text was updated successfully, but these errors were encountered: