chore: upgrade to AGP 8.0 (#1476)

thatfiredev · web-flow · commit ab037a053982 · 2023-04-20T23:55:33.000+01:00
* chore: upgrade to AGP 8.0

* chore: update gh actions to jdk 17

* add jvm args for ktlint

* chore: compile with jvmTarget 1.8

* chore(config): compile with jvmTarget 1.8

* chore: use Java 17 for lint

* chore(*): update android build tools version to 8.0
diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml
@@ -9,10 +9,10 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v2
-    - name: set up JDK 11
+    - name: set up JDK 17
       uses: actions/setup-java@v1
       with:
-        java-version: 11
+        java-version: 17
     - name: Check Snippets
       run: python scripts/checksnippets.py
     - name: Copy mock google_services.json
diff --git a/admob/app/build.gradle b/admob/app/build.gradle
@@ -32,8 +32,13 @@ android {
             excludes += ['LICENSE.txt']
         }
     }
-
-
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_11
+        targetCompatibility JavaVersion.VERSION_11
+    }
+    kotlinOptions {
+        jvmTarget = '11'
+    }
     buildFeatures {
         viewBinding = true
     }
diff --git a/admob/build.gradle b/admob/build.gradle
@@ -7,7 +7,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.4.2'
+        classpath 'com.android.tools.build:gradle:8.0.0'
         classpath 'com.google.gms:google-services:4.3.15'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'
     }
diff --git a/analytics/app/build.gradle b/analytics/app/build.gradle
@@ -27,6 +27,14 @@ android {
         }
     }
 
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_11
+        targetCompatibility JavaVersion.VERSION_11
+    }
+    kotlinOptions {
+        jvmTarget = '11'
+    }
+
     buildFeatures {
         viewBinding = true
     }
diff --git a/analytics/build.gradle b/analytics/build.gradle
@@ -7,7 +7,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.4.2'
+        classpath 'com.android.tools.build:gradle:8.0.0'
         classpath 'com.google.gms:google-services:4.3.15'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'
     }
diff --git a/appdistribution/app/build.gradle b/appdistribution/app/build.gradle
@@ -24,7 +24,13 @@ android {
             proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
         }
     }
-
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_11
+        targetCompatibility JavaVersion.VERSION_11
+    }
+    kotlinOptions {
+        jvmTarget = '11'
+    }
 
     buildFeatures {
         viewBinding = true
diff --git a/appdistribution/build.gradle b/appdistribution/build.gradle
@@ -9,7 +9,7 @@ buildscript {
     }
     dependencies {
         classpath 'com.google.gms:google-services:4.3.15'
-        classpath 'com.android.tools.build:gradle:7.4.2'
+        classpath 'com.android.tools.build:gradle:8.0.0'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'
     }
 }
diff --git a/auth/app/build.gradle b/auth/app/build.gradle
@@ -29,8 +29,11 @@ android {
     }
 
     compileOptions {
-        sourceCompatibility 1.8
-        targetCompatibility 1.8
+        sourceCompatibility JavaVersion.VERSION_11
+        targetCompatibility JavaVersion.VERSION_11
+    }
+    kotlinOptions {
+        jvmTarget = '11'
     }
 
     buildFeatures {
diff --git a/auth/build.gradle b/auth/build.gradle
@@ -7,7 +7,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.4.2'
+        classpath 'com.android.tools.build:gradle:8.0.0'
         classpath 'com.google.gms:google-services:4.3.15'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'
     }
diff --git a/build.gradle b/build.gradle
@@ -5,7 +5,7 @@ buildscript {
         mavenLocal()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.4.2'
+        classpath 'com.android.tools.build:gradle:8.0.0'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'
 
         classpath 'com.google.gms:google-services:4.3.15'
@@ -84,6 +84,7 @@ task("ktlint", type: JavaExec, group: "verification") {
         "--reporter=checkstyle,output=${outputFile}",
         "**/*.kt",
     ]
+    jvmArgs "--add-opens=java.base/java.lang=ALL-UNNAMED"
 }
 
 task clean(type: Delete) {
diff --git a/config/app/build.gradle b/config/app/build.gradle
@@ -26,6 +26,13 @@ android {
             proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
         }
     }
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_11
+        targetCompatibility JavaVersion.VERSION_11
+    }
+    kotlinOptions {
+        jvmTarget = '11'
+    }
 
     buildFeatures {
         viewBinding = true
diff --git a/config/build.gradle b/config/build.gradle
@@ -7,7 +7,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.4.2'
+        classpath 'com.android.tools.build:gradle:8.0.0'
         classpath 'com.google.gms:google-services:4.3.15'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'
     }
diff --git a/crash/app/build.gradle b/crash/app/build.gradle
@@ -31,6 +31,13 @@ android {
             proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
         }
     }
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_11
+        targetCompatibility JavaVersion.VERSION_11
+    }
+    kotlinOptions {
+        jvmTarget = '11'
+    }
 
     buildFeatures {
         viewBinding = true
diff --git a/crash/build.gradle b/crash/build.gradle
@@ -7,7 +7,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.4.2'
+        classpath 'com.android.tools.build:gradle:8.0.0'
         classpath 'com.google.gms:google-services:4.3.15'
         classpath 'com.google.firebase:firebase-crashlytics-gradle:2.9.4'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'
diff --git a/database/app/build.gradle b/database/app/build.gradle
@@ -27,6 +27,13 @@ android {
             signingConfig signingConfigs.debug
         }
     }
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_11
+        targetCompatibility JavaVersion.VERSION_11
+    }
+    kotlinOptions {
+        jvmTarget = '11'
+    }
 
     buildFeatures {
         viewBinding = true
diff --git a/database/build.gradle b/database/build.gradle
@@ -7,7 +7,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.4.2'
+        classpath 'com.android.tools.build:gradle:8.0.0'
         classpath 'com.google.gms:google-services:4.3.15'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'
     }
diff --git a/dynamiclinks/app/build.gradle b/dynamiclinks/app/build.gradle
@@ -39,6 +39,13 @@ android {
             resValue "string", "dynamic_links_uri_prefix", "https://YOUR_APP.page.link"
         }
     }
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_11
+        targetCompatibility JavaVersion.VERSION_11
+    }
+    kotlinOptions {
+        jvmTarget = '11'
+    }
 
     buildFeatures {
         viewBinding = true
diff --git a/dynamiclinks/build.gradle b/dynamiclinks/build.gradle
@@ -7,7 +7,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.4.2'
+        classpath 'com.android.tools.build:gradle:8.0.0'
         classpath 'com.google.gms:google-services:4.3.15'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'
     }
diff --git a/firestore/app/build.gradle b/firestore/app/build.gradle
@@ -34,6 +34,13 @@ android {
             signingConfig signingConfigs.debug
         }
     }
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_11
+        targetCompatibility JavaVersion.VERSION_11
+    }
+    kotlinOptions {
+        jvmTarget = '11'
+    }
 
     buildFeatures {
         viewBinding = true
diff --git a/firestore/build.gradle b/firestore/build.gradle
@@ -7,7 +7,7 @@ buildscript {
         mavenLocal()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.4.2'
+        classpath 'com.android.tools.build:gradle:8.0.0'
         classpath 'com.google.gms:google-services:4.3.15'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'
         classpath 'androidx.navigation:navigation-safe-args-gradle-plugin:2.5.3'
diff --git a/functions/app/build.gradle b/functions/app/build.gradle
@@ -28,6 +28,13 @@ android {
             signingConfig signingConfigs.debug
         }
     }
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_11
+        targetCompatibility JavaVersion.VERSION_11
+    }
+    kotlinOptions {
+        jvmTarget = '11'
+    }
 
     buildFeatures {
         viewBinding = true
diff --git a/functions/build.gradle b/functions/build.gradle
@@ -7,7 +7,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.4.2'
+        classpath 'com.android.tools.build:gradle:8.0.0'
         classpath 'com.google.gms:google-services:4.3.15'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'
     }
diff --git a/gradle.properties b/gradle.properties
@@ -1,8 +1,11 @@
-org.gradle.jvmargs=-Xmx6g -XX:MaxPermSize=6g -XX:ReservedCodeCacheSize=2g -Dfile.encoding=UTF-8
+org.gradle.jvmargs=-Xmx6g -XX:MaxMetaspaceSize=6g -XX:ReservedCodeCacheSize=2g -Dfile.encoding=UTF-8
 # TODO there's a bug when using parallel modules: https://issuetracker.google.com/issues/62805436
 org.gradle.parallel=true
 org.gradle.configureondemand=true
 org.gradle.caching=true
 
 ## Play and Firebase moving to AndroidX
 android.useAndroidX=true
+android.defaults.buildfeatures.buildconfig=true
+android.nonTransitiveRClass=false
+android.nonFinalResIds=false
diff --git a/gradle/wrapper/gradle-wrapper.properties b/gradle/wrapper/gradle-wrapper.properties
@@ -1,5 +1,5 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.5.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.0.2-bin.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
diff --git a/inappmessaging/app/build.gradle b/inappmessaging/app/build.gradle
@@ -24,7 +24,13 @@ android {
             proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
         }
     }
-
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_11
+        targetCompatibility JavaVersion.VERSION_11
+    }
+    kotlinOptions {
+        jvmTarget = '11'
+    }
 
     buildFeatures {
         viewBinding = true
diff --git a/inappmessaging/build.gradle b/inappmessaging/build.gradle
@@ -9,7 +9,7 @@ buildscript {
     }
     dependencies {
         classpath 'com.google.gms:google-services:4.3.15'
-        classpath 'com.android.tools.build:gradle:7.4.2'
+        classpath 'com.android.tools.build:gradle:8.0.0'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'
     }
 }
diff --git a/internal/lint/build.gradle b/internal/lint/build.gradle
@@ -8,12 +8,12 @@ repositories {
 }
 
 java {
-    targetCompatibility = JavaVersion.VERSION_11
-    sourceCompatibility = JavaVersion.VERSION_11
+    targetCompatibility = JavaVersion.VERSION_17
+    sourceCompatibility = JavaVersion.VERSION_17
 }
 
 compileKotlin {
-    kotlinOptions.jvmTarget = "11"
+    kotlinOptions.jvmTarget = "17"
 }
 
 dependencies {
diff --git a/messaging/app/build.gradle b/messaging/app/build.gradle
@@ -32,6 +32,13 @@ android {
             excludes += ['LICENSE.txt']
         }
     }
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_11
+        targetCompatibility JavaVersion.VERSION_11
+    }
+    kotlinOptions {
+        jvmTarget = '11'
+    }
 
 
     buildFeatures {
diff --git a/messaging/build.gradle b/messaging/build.gradle
@@ -7,7 +7,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.4.2'
+        classpath 'com.android.tools.build:gradle:8.0.0'
         classpath 'com.google.gms:google-services:4.3.15'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'
     }
diff --git a/perf/app/build.gradle b/perf/app/build.gradle
@@ -33,6 +33,13 @@ android {
             }
         }
     }
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_11
+        targetCompatibility JavaVersion.VERSION_11
+    }
+    kotlinOptions {
+        jvmTarget = '11'
+    }
     buildFeatures {
         viewBinding = true
     }
diff --git a/perf/build.gradle b/perf/build.gradle
@@ -7,7 +7,7 @@ buildscript {
         mavenLocal()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.4.2'
+        classpath 'com.android.tools.build:gradle:8.0.0'
         classpath 'com.google.firebase:perf-plugin:1.4.2'
         classpath 'com.google.gms:google-services:4.3.15'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'
diff --git a/storage/app/build.gradle b/storage/app/build.gradle
@@ -25,6 +25,13 @@ android {
             proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
         }
     }
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_11
+        targetCompatibility JavaVersion.VERSION_11
+    }
+    kotlinOptions {
+        jvmTarget = '11'
+    }
 
     buildFeatures {
         viewBinding = true
diff --git a/storage/build.gradle b/storage/build.gradle
@@ -7,7 +7,7 @@ buildscript {
         mavenCentral()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:7.4.2'
+        classpath 'com.android.tools.build:gradle:8.0.0'
         classpath 'com.google.gms:google-services:4.3.15'
         classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'
     }

Original file line number	Diff line number	Diff line change
`@@ -32,8 +32,13 @@ android {`
`32`	`32`	`excludes += ['LICENSE.txt']`
`33`	`33`	`}`
`34`	`34`	`}`
`35`		`-`
`36`		`-`
	`35`	`+ compileOptions {`
	`36`	`+ sourceCompatibility JavaVersion.VERSION_11`
	`37`	`+ targetCompatibility JavaVersion.VERSION_11`
	`38`	`+ }`
	`39`	`+ kotlinOptions {`
	`40`	`+ jvmTarget = '11'`
	`41`	`+ }`
`37`	`42`	`buildFeatures {`
`38`	`43`	`viewBinding = true`
`39`	`44`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ buildscript {`
`7`	`7`	`mavenCentral()`
`8`	`8`	`}`
`9`	`9`	`dependencies {`
`10`		`- classpath 'com.android.tools.build:gradle:7.4.2'`
	`10`	`+ classpath 'com.android.tools.build:gradle:8.0.0'`
`11`	`11`	`classpath 'com.google.gms:google-services:4.3.15'`
`12`	`12`	`classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'`
`13`	`13`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,14 @@ android {`
`27`	`27`	`}`
`28`	`28`	`}`
`29`	`29`
	`30`	`+ compileOptions {`
	`31`	`+ sourceCompatibility JavaVersion.VERSION_11`
	`32`	`+ targetCompatibility JavaVersion.VERSION_11`
	`33`	`+ }`
	`34`	`+ kotlinOptions {`
	`35`	`+ jvmTarget = '11'`
	`36`	`+ }`
	`37`	`+`
`30`	`38`	`buildFeatures {`
`31`	`39`	`viewBinding = true`
`32`	`40`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,13 @@ android {`
`24`	`24`	`proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'`
`25`	`25`	`}`
`26`	`26`	`}`
`27`		`-`
	`27`	`+ compileOptions {`
	`28`	`+ sourceCompatibility JavaVersion.VERSION_11`
	`29`	`+ targetCompatibility JavaVersion.VERSION_11`
	`30`	`+ }`
	`31`	`+ kotlinOptions {`
	`32`	`+ jvmTarget = '11'`
	`33`	`+ }`
`28`	`34`
`29`	`35`	`buildFeatures {`
`30`	`36`	`viewBinding = true`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ buildscript {`
`9`	`9`	`}`
`10`	`10`	`dependencies {`
`11`	`11`	`classpath 'com.google.gms:google-services:4.3.15'`
`12`		`- classpath 'com.android.tools.build:gradle:7.4.2'`
	`12`	`+ classpath 'com.android.tools.build:gradle:8.0.0'`
`13`	`13`	`classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'`
`14`	`14`	`}`
`15`	`15`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,11 @@ android {`
`29`	`29`	`}`
`30`	`30`
`31`	`31`	`compileOptions {`
`32`		`- sourceCompatibility 1.8`
`33`		`- targetCompatibility 1.8`
	`32`	`+ sourceCompatibility JavaVersion.VERSION_11`
	`33`	`+ targetCompatibility JavaVersion.VERSION_11`
	`34`	`+ }`
	`35`	`+ kotlinOptions {`
	`36`	`+ jvmTarget = '11'`
`34`	`37`	`}`
`35`	`38`
`36`	`39`	`buildFeatures {`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ buildscript {`
`5`	`5`	`mavenLocal()`
`6`	`6`	`}`
`7`	`7`	`dependencies {`
`8`		`- classpath 'com.android.tools.build:gradle:7.4.2'`
	`8`	`+ classpath 'com.android.tools.build:gradle:8.0.0'`
`9`	`9`	`classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.20'`
`10`	`10`
`11`	`11`	`classpath 'com.google.gms:google-services:4.3.15'`
`@@ -84,6 +84,7 @@ task("ktlint", type: JavaExec, group: "verification") {`
`84`	`84`	`"--reporter=checkstyle,output=${outputFile}",`
`85`	`85`	`"*/.kt",`
`86`	`86`	`]`
	`87`	`+ jvmArgs "--add-opens=java.base/java.lang=ALL-UNNAMED"`
`87`	`88`	`}`
`88`	`89`
`89`	`90`	`task clean(type: Delete) {`
Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,13 @@ android {`
`26`	`26`	`proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'`
`27`	`27`	`}`
`28`	`28`	`}`
	`29`	`+ compileOptions {`
	`30`	`+ sourceCompatibility JavaVersion.VERSION_11`
	`31`	`+ targetCompatibility JavaVersion.VERSION_11`
	`32`	`+ }`
	`33`	`+ kotlinOptions {`
	`34`	`+ jvmTarget = '11'`
	`35`	`+ }`
`29`	`36`
`30`	`37`	`buildFeatures {`
`31`	`38`	`viewBinding = true`
Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,13 @@ android {`
`31`	`31`	`proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'`
`32`	`32`	`}`
`33`	`33`	`}`
	`34`	`+ compileOptions {`
	`35`	`+ sourceCompatibility JavaVersion.VERSION_11`
	`36`	`+ targetCompatibility JavaVersion.VERSION_11`
	`37`	`+ }`
	`38`	`+ kotlinOptions {`
	`39`	`+ jvmTarget = '11'`
	`40`	`+ }`
`34`	`41`
`35`	`42`	`buildFeatures {`
`36`	`43`	`viewBinding = true`
Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,13 @@ android {`
`27`	`27`	`signingConfig signingConfigs.debug`
`28`	`28`	`}`
`29`	`29`	`}`
	`30`	`+ compileOptions {`
	`31`	`+ sourceCompatibility JavaVersion.VERSION_11`
	`32`	`+ targetCompatibility JavaVersion.VERSION_11`
	`33`	`+ }`
	`34`	`+ kotlinOptions {`
	`35`	`+ jvmTarget = '11'`
	`36`	`+ }`
`30`	`37`
`31`	`38`	`buildFeatures {`
`32`	`39`	`viewBinding = true`