Merge branch 'master' of github.com:firebug/websocket-monitor

Author: janodvarko

chrome/content/network-content-script.js

@@ -17,47 +17,56 @@
  * The icons serves also as a link to the 'Web Socket'
  * panel.
  */
-window.on(EVENTS.RECEIVED_REQUEST_HEADERS, (_, from) => {
-  let item = NetMonitorView.RequestsMenu.getItemByValue(from);
-  if (!isWsUpgradeRequest(item)) {
-    return;
-  }
+if (EVENTS.REQUEST_ITEM_CLICKED) {
+  window.on(EVENTS.REQUEST_ITEM_CLICKED, (_, e, item) => {
+    let target = ".request-list-item.websocket .requests-menu-method";
+    if (e.target.closest(target)) {
+      navigateToWebSocketPanel(item.id);
+    }
+  });
+} else {
+  window.on(EVENTS.RECEIVED_REQUEST_HEADERS, (_, from) => {
+    let item = NetMonitorView.RequestsMenu.getItemByValue(from);
+    if (!isWsUpgradeRequest(item)) {
+      return;
+    }
 
-  // Append WebSocket icon in the UI
-  let hbox = item._target;
+    // Append WebSocket icon in the UI
+    let hbox = item._target;
 
-  let method = hbox.querySelector(".requests-menu-method");
-  method.classList.add("websocket");
+    let method = hbox.querySelector(".requests-menu-method");
+    method.classList.add("websocket");
 
-  // Fx 45 changed the DOM layout in the network panel and also
-  // the WS icon isn't overlapping the original status icon now.
-  // But, we need a little indentation for pre Fx45.
-  let statusIconNode = hbox.querySelector(".requests-menu-status-icon");
-  if (!statusIconNode) {
-    // We are in pre Fx45 world, use a little indentation.
-    method.classList.add("websocket-indent");
-  }
-
-  // Register click handler and emit an event that is handled
-  // in the 'WsmNetMonitorOverlay' overlay.
-  // xxxHonza: this registers multiple listeners on the window
-  // object that are all executed when the user clicks on the
-  // WS icon. FIXME
-  window.addEventListener("click", event => {
-    if (event.target.classList.contains("websocket")) {
-      navigateToWebSocketPanel(from);
+    // Fx 45 changed the DOM layout in the network panel and also
+    // the WS icon isn't overlapping the original status icon now.
+    // But, we need a little indentation for pre Fx45.
+    let statusIconNode = hbox.querySelector(".requests-menu-status-icon");
+    if (!statusIconNode) {
+      // We are in pre Fx45 world, use a little indentation.
+      method.classList.add("websocket-indent");
     }
-  });
 
-  // Do not open the Network panel side-bar if the user clicks
-  // on the WS icon.
-  window.addEventListener("mousedown", event => {
-    if (event.target.classList.contains("websocket")) {
-      event.stopPropagation();
-      event.preventDefault();
-    }
-  }, true);
-});
+    // Register click handler and emit an event that is handled
+    // in the 'WsmNetMonitorOverlay' overlay.
+    // xxxHonza: this registers multiple listeners on the window
+    // object that are all executed when the user clicks on the
+    // WS icon. FIXME
+    window.addEventListener("click", event => {
+      if (event.target.classList.contains("websocket")) {
+        navigateToWebSocketPanel(from);
+      }
+    });
+
+    // Do not open the Network panel side-bar if the user clicks
+    // on the WS icon.
+    window.addEventListener("mousedown", event => {
+      if (event.target.classList.contains("websocket")) {
+        event.stopPropagation();
+        event.preventDefault();
+      }
+    }, true);
+  });
+}
 
 /**
  * Handle Response body displayed event.

chrome/skin/classic/netmonitor.css

@@ -4,10 +4,11 @@
 /* Network Panel */
 
 /* Web Socket Icon */
-.requests-menu-method.websocket {
+.requests-menu-method.websocket,
+.request-list-item.websocket .requests-menu-method {
   background-image: url("./tool-websockets.svg");
   background-repeat: no-repeat;
-  background-position: 0 1px;
+  background-position: left center;
 }
 
 /* Make sure the icon works in all themes */

package.json

@@ -15,7 +15,7 @@
   "license": "BSD-3-Clause",
   "icon": "chrome://websocketmonitor/skin/icon-32-color.png",
   "homepage": "https://github.com/firebug/websocket-monitor/wiki",
-  "version": "0.6.4",
+  "version": "0.6.5",
   "main": "lib/index",
   "repository": {
     "type": "git",
@@ -40,6 +40,9 @@
     "eslint:watch": "esw -w data/**/*.js chrome/"
   },
   "preferences-branch": "websocketmonitor",
+  "permissions": {
+    "multiprocess": true
+  },
   "preferences": [
     {
       "name": "max_entries",