Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide search-disabled groups #161

Open
avidseeker opened this issue Mar 16, 2024 · 7 comments
Open

Hide search-disabled groups #161

avidseeker opened this issue Mar 16, 2024 · 7 comments

Comments

@avidseeker
Copy link

config.ini includes hide_groups to exclude passwords from showing up the menu. However, KeePassXC already provides this functionality in group properties: right click > group > search: Enabled/Disabled/Inherited from parent group.

@firecat53
Copy link
Owner

Ok, I see that KeepassXC has the ability to hide a group from search. I don't
understand how that's relevant to Keepmenu?

@vaygr
Copy link
Contributor

vaygr commented Mar 18, 2024

Maybe the ask here is to move this to entry properties and control within keepmenu instead of using custom ini kv?

@avidseeker
Copy link
Author

Ok, I see that KeepassXC has the ability to hide a group from search. I don't understand how that's relevant to Keepmenu?

It is relevant because keepmenu already implements it.

I'm saying that the hide_groups feature in keepmenu is re-implementing something KeePassXC already has which is "exclude from search". Why not read this property directly from kdbx? especially that it is better with hierarchical groups (see the "inherited from parent group" option).

@firecat53
Copy link
Owner

firecat53 commented Mar 18, 2024

Pykeepass doesn't implement that feature. Is it actually a kbdx feature or just a KeepassXC feature?

Edit: Here is the XML spec for kbdx. I didn't see anything relevant to group visibility during search, but it's not exactly easy to read 😁

@firecat53
Copy link
Owner

I'm going to close this, as it doesn't seem the requested feature is part of the kdbx spec. If I'm wrong, please re-open and I'll take a look. Thanks!

@avidseeker
Copy link
Author

I think it's

<xs:element name="EnableSearching" type="TNullableBoolEx" minOccurs="0" />

If I wasn't mistaken.

@firecat53 firecat53 reopened this Mar 28, 2024
@firecat53
Copy link
Owner

Ah, I see now. Thanks for that! Re-opening.

Here's
the actual spec definition for EnableSearching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants