-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define supported Go versions #364
Comments
Go versions in the world right now
Right now, there are Go 1.19 and 1.18. Go versions <= 1.17 are no longer supported. Linux distributions
Amazon-owned Go packageshttps://github.com/aws/aws-sdk-go-v2
https://github.com/aws/aws-sdk-go
|
Seeing this on other recent PRs (e.g. #440). Looks like our dependency
latest releases of |
Maybe, version of the ltag binary must be setted using |
To me the way is to drop support for Go <= v1.16. v1.17 just ended support in August 2022 and users may still be in transition. Also we should pin the dependency versions for reproducible builds but that is a separate issue. |
As @kzys mentioned, that would require users on Debian 11 or Ubuntu 20.04 to download go outside of their normal package managers. Debian 11 just went stable last year and is supported for 4 more years, and Ubuntu 20.04 is still supported for 2 years. I don't think it's unreasonable to say we will only support go versions that are still supported upstream, but I don't think that's the only consideration. |
That's fair I wasn't viewing support from the linux distribution pov. Now I'm conflicted again. I want to consider those users, but 4 more years of Go 1.15 support 👀 |
I agree with @Kern-- as a Firecracker go SDK user these "feature" is quite important to me as I'm working in constrained environments. Plus, as you said @austinvazquez pin the dependency versions is definitely a separate issue except if you introduce a range of supported Go versions as it is the case now. |
I've updated my comment above. Dropping Go 1.15 and 1.17 support may be a bummer for Ubuntu 18.04 LTS users, but other distros seem fine. |
The SDK currently doesn't have a policy regarding supported Go versions. We have been supporting Go 1.11 for a while even Go team doesn't support the version.
Right now, the motivation tends to come from dependencies. If they are having vulnerabilities and we want to upgrade them, we tend to realize that newer dependencies don't support older Go versions.
We probably should have a version supporting policy upfront, instead of deciding case-by-case basis. If supporting old Go versions have some value, we may be okay to ask our dependencies to support them.
The text was updated successfully, but these errors were encountered: