Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./build-setup.sh stops at step 9 (re-mounting the disk-mount folder) #309

Open
wadidf opened this issue Aug 14, 2024 · 6 comments
Open

./build-setup.sh stops at step 9 (re-mounting the disk-mount folder) #309

wadidf opened this issue Aug 14, 2024 · 6 comments

Comments

@wadidf
Copy link

wadidf commented Aug 14, 2024

https://github.com/firesim/FireMarshal/blame/74ac78a0b9ae106dff9c5bdfc3a89847ae11d357/wlutil/wlutil.py#L598C12-L598C12

./build-setup.sh riscv-tools stops at step 9
the cause is the assertion in line 598 (wlutil.py) regarding the mount-point of disk-mount folder.
Well the folder is already mounted before, and the assertion will stop the setup script.
As a workaround I commented the line and re-run the build script after sourcing the environment (to have $RISCV defined) and skipping the steps : 1 to 8.
But it would be efficient to replace the assertion by a test and warning.

@cavendish98
Copy link

cavendish98 commented Aug 20, 2024

I have this problem too, how did you solve it,and after that you complete chipyard fully setup?

@abejgonzalez
Copy link
Contributor

I think this should be fixed now. There was an issue w/ Ubuntu 22 versions of mountpoint returning a different error code than Ubuntu 20 versions.

@cavendish98
Copy link

I think this should be fixed now. There was an issue w/ Ubuntu 22 versions of mountpoint returning a different error code than Ubuntu 20 versions.

no,it didn't work

@xiuhu17
Copy link

xiuhu17 commented Sep 22, 2024

Same issue.....

@wadidf
Copy link
Author

wadidf commented Sep 22, 2024

It is fixed in Firemarshal (in the code :wlutil.py lines 598-599)

598     # mountpoint on Ubuntu 20.* returns 1 (on 22.* it returns 32) for an empty folder
599        assert ret == 1 or ret == 32, f"{mntPath} already mounted. Somethings wrong"

But Chipyard is not yet fetching the updated version.
@xiuhu17 and @cavendish98, as a workaround, you can apply yourself the modification (the assert line)
then in the (same) terminal run the commands :

source  env.sh
./build-setup.sh riscv-tools -s 1 -s 2 -s 3 -s 4 -s 5 -s 6 -s 7 -s 8

@xiuhu17
Copy link

xiuhu17 commented Sep 22, 2024

It is fixed in Firemarshal (in the code :wlutil.py lines 598-599)

598     # mountpoint on Ubuntu 20.* returns 1 (on 22.* it returns 32) for an empty folder
599        assert ret == 1 or ret == 32, f"{mntPath} already mounted. Somethings wrong"

But Chipyard is not yet fetching the updated version. @xiuhu17 and @cavendish98, as a workaround, you can apply yourself the modification (the assert line) then in the (same) terminal run the commands :

source  env.sh
./build-setup.sh riscv-tools -s 1 -s 2 -s 3 -s 4 -s 5 -s 6 -s 7 -s 8

Thanks for letting me know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants