Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DownloadTimeout and Retry #52

Closed
volllly opened this issue Oct 19, 2022 · 1 comment · Fixed by #91
Closed

Implement DownloadTimeout and Retry #52

volllly opened this issue Oct 19, 2022 · 1 comment · Fixed by #91
Assignees
@pawelvds
Labels
feature-request New feature or request planned-feature A feature that was planned and committed to by the maintainers

Comments

@volllly
Copy link
Contributor

volllly commented Oct 19, 2022 •
edited
Loading

The ConfigurationDownloader and PackageDownloader currently don't respect the DownloadTimeoutSec and DownloadRetry parameters of the LauncherConfiguration.

We should implement these functionalities in both downloaders and add appropriate tests.
@volllly volllly added feature-request New feature or request planned-feature A feature that was planned and committed to by the maintainers labels Oct 19, 2022
@volllly
Copy link
Contributor Author

volllly commented Jun 15, 2023

We could use polly to implement this

See https://stackoverflow.com/a/52808545 for a short usage example.

@pawelvds pawelvds self-assigned this Jun 15, 2023
@pawelvds pawelvds linked a pull request Jun 19, 2023 that will close this issue
Implement DownloadTimeout and Retry #91
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawelvds pawelvds

Labels
feature-request New feature or request planned-feature A feature that was planned and committed to by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement DownloadTimeout and Retry fiskaltrust/middleware-launcher
2 participants
@volllly @pawelvds