Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFKA with Voucher payment type don´t sum up correct #302

Open
2 tasks done
forsthug opened this issue Jun 3, 2024 · 3 comments
Open
2 tasks done

DFKA with Voucher payment type don´t sum up correct #302

forsthug opened this issue Jun 3, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@forsthug
Copy link
Contributor

forsthug commented Jun 3, 2024

Describe the bug

When adding a Voucher via Payitem, the paid sum is is not including the Voucher.

To Reproduce

Send receipt with

  "cbPayItems": [
    {
      "Quantity": 1,
      "Description": "Gutschein Werbering",
      "Amount": 50,
      "ftPayItemCase": "4919338167972134925",
      "ftPayItemCaseData": "",
      "AccountNumber": "",
      "CostCenter": "",
      "MoneyGroup": "",
      "MoneyNumber": "",
      "Moment": "2024-05-16T08:06:18Z"
    },
    {
      "Quantity": 1,
      "Description": "Bargeld",
      "Amount": 5,
      "ftPayItemCase": "4919338167972134913",
      "ftPayItemCaseData": "",
      "AccountNumber": "",
      "CostCenter": "",
      "MoneyGroup": "",
      "MoneyNumber": "",
      "Moment": "2024-05-16T08:06:29Z"
    },

dfka:

        "head": {
          "type": "Beleg",
          "closing_cash_register": {
            "id": ""
          },
          "storno": false,
          "id": "",
          "number": 88,
          "timestamp_start": "2024-05-16T07:30:36Z",
          "timestamp_end": "2024-05-16T07:33:59Z",
          "user": {
            "id": "Support",
            "name": "Support"
          },
          "allocation_groups": [
            "dfae9f37-1bf3-4ad6-9c88-bdb9f45faf31"
          ],
          "custom_fields": {
            "QueueItemId": "..."
          }
        },
        "data": {
          "full_amount_incl_vat": 5.00,
          "amounts_per_vat_id": [
            {
              "id": 1,
              "incl_vat": 55.00,
              "excl_vat": 46.22,
              "vat": 8.78
            },
            {
              "id": 6,
              "incl_vat": 0.00,
              "excl_vat": 0.00,
              "vat": 0.00
            },
            {
              "id": 5,
              "incl_vat": -50.00,
              "excl_vat": -50.00,
              "vat": 0.00
            }
          ],
          "type": "",
          "payment_types": [
            {
              "type": "Bar",
              "currency_code": "EUR",
              "amount": 5.00
            },
            {
              "type": "Bar",
              "currency_code": "EUR",
              "amount": 0.00
            }
          ],

voucherDfka.json
testVoucher.json

Further technical details & context

Check reference the dsfinvk-definition on multiuse vouchers

Tasks

  • Fix the incorrect summing for all ways of doing vouchers (chargeitem voucher, payitem voucher / buying + redeeming)
  • Test by either reproducing the issue or using the Queue from the inquiry, and importing the data in AmadeusVerify
@forsthug forsthug added the bug Something isn't working label Jun 3, 2024
@TSchmiedlechner
Copy link
Member

Link to the inquiry in Slack:
https://fiskaltrust.slack.com/archives/C06DK7GAV8D/p1717049654686629

@forsthug forsthug self-assigned this Jun 24, 2024
@forsthug
Copy link
Contributor Author

forsthug commented Jul 3, 2024

@forsthug
Copy link
Contributor Author

Fehler 515

Image

Dsfinvk Definition

In den Bestellungen findet sich keine Definition wo das Vorzeichen gesetzt wird. Generell gilt:

Image

Fix MW

https://github.com/fiskaltrust/middleware/pull/320/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants