Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Fix all services methods names #187

Open
ostorc opened this issue Sep 27, 2021 · 1 comment
Open

Refactoring: Fix all services methods names #187

ostorc opened this issue Sep 27, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ostorc
Copy link
Contributor

ostorc commented Sep 27, 2021

Currently we have quite a mess in names of methods inside services. All asynchronous methods should have suffix *Async. Requirement for closing this issue is to have consistent naming scheme across whole codebase.

Things to discussion:

  • Will we just add suffix Async to all incorrectly named methods, or will we remove suffix Async from codebase, since most of our methods are asynchronous anyway?
@ostorc ostorc added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Sep 27, 2021
@stepech
Copy link
Contributor

stepech commented Sep 28, 2021 •
edited
Loading

https://github.com/DSharpPlus/DSharpPlus/blob/3f3e6415ee7b47103daa74849bf9db2d3ee67954/.editorconfig
?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ostorc @stepech