Use spaceapi-kt for parsing, add v14 support #85
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I hope this makes it a bit easier to read :)
Besides replacing the JSON / HashMap based parser, the whole layout setup code was also refactored. A few helpers were added to make the code a bit cleaner. The widget can be added but currently doesn't seem to work on Android 11. However, as far as I know, it did not work previously either. Probably some APIs changed.
Co-authored-by: Matthias Jacob <[email protected]>
This was referenced Nov 23, 2020
Closed
This allows landing PRs and releases even if not all translation files are up to date. (If a string is missing, the english string is used as fallback. That's fine, translations should be done on a best-effort basis.)
dbrgn
changed the title
dbrgn
added a commit
to spaceapi-community/my-hackerspace
that referenced
this pull request
Feb 7, 2021
Use spaceapi-kt for parsing, add v14 support fixme-lausanne#85
|
I forked to https://github.com/spaceapi-community/my-hackerspace and merged the branch there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #84, I replaced the old parser with a spaceapi-kt. This drops v0.12 support but adds v14 support. (There are only 8 spaces left with a v0.12 endpoint. They should upgrade.)
Besides replacing the parser and the HashMap based data management, the whole layout setup code was also refactored. A few helpers were added to make the code a bit cleaner. I also added support for unit testing.
The widget compiles and can be added to the home screen, but currently it doesn't seem to work on Android 11. However, as far as I can tell, it did not work previously either. Probably some APIs changed.
Some translation strings are still missing. I updated EN and DE (and merged in #82 afterwards).
Size impact: Release APK size increased from 71 KiB to 765 KiB. But I think that's still perfectly fine 🙂
Fixes #84. Fixes #78. Replaces #80. Replaces #83. Replaces #82.
PS: If you need help with maintaining this app, I'll happily help out! It would also be an option to transfer the repo to https://github.com/spaceapi-community/ for better shared maintenance.