Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Volume setting to min /max #5

Open
volschin opened this issue Sep 29, 2020 · 3 comments
Open

Adjust Volume setting to min /max #5

volschin opened this issue Sep 29, 2020 · 3 comments

Comments

@volschin
Copy link
Contributor

If volume ist set to a value outside min/max the value is accepted.

It should be adjusted to be between min and max. I'm not sure if this is really a problem of the extension or should better be handled in the core.

@fjgalesloot
Copy link
Owner

Is the value accepted by Roon and is the volume really set beyond the min/max limits? Or is de value accepted but is the volume not changed outside its boundaries?

@volschin
Copy link
Contributor Author

volschin commented Sep 29, 2020

2020-09-29-15-52-00
my min / max is -70 /-40 dB, I accidently set to 60 instead of -60. It was very loud.
I tried it again with -30 and it goes to -30.
2020-09-29-16-05-36

@fjgalesloot
Copy link
Owner

The extension could check the min/max and ignore commands when outside the range as this is published in the Roon Api.
This has no priotity right now for me, as not setting a value outside the range 'solves the issue' ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants