You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
add pre-commit hooks and update documentation (#707)
- Introduced pre-commit hooks for code quality and consistency.
- Updated CHANGELOG.md and CONTRIBUTING.md for new setup instructions.
- Added 'pre-commit' to dev dependencies in pyproject.toml.
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+14-10Lines changed: 14 additions & 10 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -38,19 +38,23 @@ Issues and engagement in open discussions are also welcome.
38
38
* The content should have line breaks after 72 characters.
39
39
* The content should describe what was done and why it was done, but not how it was done.
40
40
41
+
### Pre-Commit Hooks
42
+
* We use pre-commit hooks to sanitize files before commiting
43
+
* Install the pre-commit hooks with `pre-commit install` in the root directory
44
+
41
45
### Pull Request and Definition of Done
42
46
* draft a Pull Request as soon as possible to signal your commitment.
43
47
* write a clear description of what a maintainer have to expect from your PR.
44
-
* add an entry in the CHANGELOG.md file for your feature, improvement or bugfix.
48
+
* add an entry in the [CHANGELOG.md](https://github.com/fkie-cad/Logprep/blob/main/CHANGELOG.md) file for your feature, improvement or bugfix.
45
49
* add the needed documentation in the docs.
46
50
* add tests for your work.
47
51
* ensure all tests run.
48
-
* if you done all of the above, add a maintainer for review and mark your PR as ready.
52
+
* if you have done all of the above, add a maintainer for review and mark your PR as ready.
49
53
50
54
### Deprecations
51
-
* If a function or features gets deprecated a warning should be logged with `logger.warning`. The message should start with `[Deprecation]:` and end with an indication when this deprecation will expire, e.g.: `[Expires with logprep=4.0.0]`.
52
-
* Furthermore the corresponding code parts should be marked with a comment starting like `# DEPRECATION: <SHORT-Name> <Comment>`. This way it is later easy to find again the lines of code that have to be revised before the deprecation will be fully removed.
53
-
* The [CHANGELOG.md](https://github.com/fkie-cad/Logprep/blob/main/CHANGELOG.md) should be updated such that the next release contains a remark that a feature will be marked as deprecated and indicating in the `Upcoming Changes` section that the deprecation will also be removed in the future.
55
+
* If a function or features gets deprecated a warning should be logged with `logger.warning`. The message should start with `[Deprecation]:` and end with an indication when this deprecation will expire, e.g.: `[Expires with logprep=4.0.0]`.
56
+
* Furthermore, the corresponding code parts should be marked with a comment starting like `# DEPRECATION: <SHORT-Name> <Comment>`. This way it is later easy to find again the lines of code that have to be revised before the deprecation will be fully removed.
57
+
* The [CHANGELOG.md](https://github.com/fkie-cad/Logprep/blob/main/CHANGELOG.md) should be updated such that the next release contains a remark that a feature will be marked as deprecated and indicating in the `Upcoming Changes` section that the deprecation will also be removed in the future.
54
58
55
59
### Code Quality and Style
56
60
* We adhere to PEP-8.
@@ -78,14 +82,14 @@ Issues and engagement in open discussions are also welcome.
78
82
* Before we make a new release we update the [CHANGELOG.md](https://github.com/fkie-cad/Logprep/blob/main/CHANGELOG.md)
79
83
There we rename the section `next release` to the version that will be released and add a new section `next release`.
80
84
This section is continuously updated during the development of the next release.
81
-
* Once this update is pushed and merged we tag a new release in git, prefixed with `v`, resulting in a tag like `v2.0.1`.
85
+
* Once this update is pushed and merged we tag a new release in git, prefixed with `v`, resulting in a tag like `v2.0.1`.
82
86
We adhere to the [SemVer](https://semver.org/) Specifications.
83
-
* Once the tag is pushed we create a release in Github. The release description should contain the changes documented
87
+
* Once the tag is pushed we create a release in GitHub. The release description should contain the changes documented
84
88
in the [CHANGELOG.md](https://github.com/fkie-cad/Logprep/blob/main/CHANGELOG.md).
85
-
* A configured Github Action then takes this published release and automatically uploads a new build to [PyPI Logprep](https://pypi.org/project/logprep/).
89
+
* A configured GitHub Action then takes this published release and automatically uploads a new build to [PyPI Logprep](https://pypi.org/project/logprep/).
86
90
87
91
### Helm Chart Release Workflow
88
92
89
93
* To release a new helm chart we update the versions in the [Chart.yaml](https://github.com/fkie-cad/Logprep/blob/main/charts/logprep/Chart.yaml) in a feature branch.
90
-
* Then we merge this change to the main branch.
91
-
* There a pipeline packages the helm chart an makes the actual helm chart release on the release page.
94
+
* Then we merge this change to the main branch.
95
+
* There a pipeline packages the helm chart and makes the actual helm chart release on the release page.
0 commit comments