Skip to content

[Serve] Bugfix when backend is native should set use_fs_serve true #1095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luoyc123 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Serve] Bugfix when backend is native should set use_fs_serve true #1095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions examples/robobrain/conf/compress.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ experiment:
entrypoint: flagscale/compress/compressor.py
runner:
hostfile: null
deploy:
use_fs_serve: true
cmds:
before_start: source activate flagscale-inference
envs:
Expand Down
6 changes: 4 additions & 2 deletions flagscale/runner/runner_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,10 @@ def __init__(self, config: DictConfig):
backend_type = f"native_{self.task_type}"
if self.config.experiment.runner.get(
"deploy", None
) is None or self.config.experiment.runner.deploy.get("use_fs_serve", False):
raise ValueError("config.experiment.deploy.use_fs_serve in YAML should be true")
) is None or not self.config.experiment.runner.deploy.get("use_fs_serve", False):
raise ValueError(
"when backend type is native, config.experiment.deploy.use_fs_serve in YAML should be true"
)

self.backend_type = backend_type

Expand Down