Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info msg "no bid received" misleading for bids below min-bid #489

Open
KgNoop opened this issue Apr 8, 2023 · 1 comment
Open

Info msg "no bid received" misleading for bids below min-bid #489

KgNoop opened this issue Apr 8, 2023 · 1 comment

Comments

@KgNoop
Copy link

KgNoop commented Apr 8, 2023

When calling the relays:
// Call the relays
var mu sync.Mutex
var wg sync.WaitGroup
for _, relay := range m.relays

the answers of the relays get checked for various circumstances. One of which is the check against the min-bid:

// Skip if value (fee) is lower than the minimum bid
if responsePayload.Value().Cmp(m.relayMinBid.BigInt()) == -1 {
log.Debug("ignoring bid below min-bid value")
return}

If the bid is below the min bid it does not get added to the Hash of Bids.
If all set relays are below min bid the Has is empty and the result/Info given bei the logs is "no bid received" which is misleading and makes room for questions about the setup.

if result.blockHash == "" {
log.Info("no bid received")
w.WriteHeader(http.StatusNoContent)
return}

Would be better to have an additional/different msg/info if the relays "all bids below min-bid - creating own block"

@metachris
Copy link
Collaborator

yeah that'd be nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants