Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a cli library #640

Open
MariusVanDerWijden opened this issue Apr 2, 2024 · 2 comments
Open

Adding a cli library #640

MariusVanDerWijden opened this issue Apr 2, 2024 · 2 comments

Comments

@MariusVanDerWijden
Copy link
Contributor

Would you be open to move the cli/flags handling from the basic-builtin handling to some library?
@ralexstokes
Copy link
Collaborator

I'd support this, esp for the right library -- is there one you have in mind?

I assume the intent is to simplify or harden the current flags infrastructure?

@MariusVanDerWijden
Copy link
Contributor Author

MariusVanDerWijden commented Apr 3, 2024 •
edited
Loading

Yes exactly, I would use https://github.com/urfave/cli which is the one we use in go-ethereum.
Theres a lot of dereferencing of flags going on which feels a bit unsafe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ralexstokes @MariusVanDerWijden