Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

running inspect on post-merge blocks fails #318

Open
pintail-xyz opened this issue Oct 25, 2022 · 2 comments
Open

running inspect on post-merge blocks fails #318

pintail-xyz opened this issue Oct 25, 2022 · 2 comments

Comments

@pintail-xyz
Copy link
Contributor

mev-inspect-py is unable to process any blocks since the merge. The reason seems to be that the 'miner' of each block is determined by looking for a trace of type reward. Presumably since there is no block subsidy post-merge, there are no longer any traces of this type.

Accordingly _get_miner_address_from_traces returns None and so create_block_from_number fails.

This could be easily fixed by getting the 'miner' from w3.eth.get_block(block_number), which returns the fee recipient for post-merge blocks.
@arsenius-clbs
Copy link

@pintail-xyz , hey. Is the fix going to be integrated into the master anytime soon?

@J1a-wei
Copy link

J1a-wei commented Jun 25, 2023

This problem is fixed?

@m-r-g-t m-r-g-t mentioned this issue Sep 18, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pintail-xyz @J1a-wei @arsenius-clbs