Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New upstream version (2.0.0) #3

Closed
ProjectSynchro opened this issue Feb 7, 2024 · 8 comments
Closed

New upstream version (2.0.0) #3

ProjectSynchro opened this issue Feb 7, 2024 · 8 comments

Comments

@ProjectSynchro
Copy link
Contributor

See: https://github.com/ytmdesktop/ytmdesktop/releases/tag/v2.0.0

Looks like the project has been rewritten, and seems to perform and function a lot better than the 1.x releases.

@ProjectSynchro
Copy link
Contributor Author

It looks like they use a much newer yarn V2 buildsystem api, which can be jerryrigged to work with a PR: flatpak/flatpak-builder-tools#252.

I had to change some of the code in that PR to get the buildsystem setup scripts to correctly generate, however it looks like there are still some issues. Until there is proper yarn2 support in https://github.com/flatpak/flatpak-builder-tools I doubt this new version can be built properly.

There is the option to create the flatpak from upstream release binaries in the interim. Perhaps that is the way to go?

@ProjectSynchro
Copy link
Contributor Author

It looks like this project has been wiped off the face of the internet, I haven't found anything on Github related to it, and their site is pointing to their github page.

Does anyone know what happened here?

@Blackcatmaxy
Copy link

Just went down a similar rabbithole, likely some DMCA thing but another repo can be found here? https://github.com/Venipa/ytmdesktop2

@ProjectSynchro
Copy link
Contributor Author

ProjectSynchro commented Apr 9, 2024

Just went down a similar rabbithole, likely some DMCA thing but another repo can be found here? https://github.com/Venipa/ytmdesktop2

I don't think it's DMCA related, as their repo isn't on the Github DMCA list, most likely the project imploded due to a lack of proper governance being set up, and some disagreements between developers. It does happen from time to time with some of these smaller projects unfortunately.

Also: their licence is EXTREMELY permissive, which may or may not be compatible with some of the underlying software that project relied on: https://creativecommons.org/public-domain/cc0/.

If there were disagreements on a re-licence for example, that would also do it.

@Alipoodle
Copy link

Alipoodle commented Apr 17, 2024

As mentioned we weren't DMCAed, we are simply waiting on GitHub to set our account to public again after a member's account was comparmised.
image

Otherwise Thank you for raising this as it is on our list to get a Flatpak version working, especially with the recent rise of the Steam Deck which has easy access to the Flatpak store.

Is there any possability that work can be done in the main repo via @ElectronForge/maker-flatpak or is this me misunderstanding the function of this repo 🙃

@Lunarequest
Copy link
Collaborator

hi, for some reason i didn't get any notifications on this repo. I'm really sorry for the delay. The issue with electronforge is that it is basically impossible to run offline. This means that we can not use it in the traditional way to build flatpaks. @ElectronForge/maker-flatpak produces a flatpak bundle that can be distributed separately and AFAIK it isn't possible to submit it to flathub. Today evening I'll look into switching to extracting the appimage and using it instead

@ProjectSynchro
Copy link
Contributor Author

ProjectSynchro commented Aug 29, 2024

I've gone ahead and opened a PR that updates the flatpak to pull from the upstream binary packages. As mentioned, the build system not really allowing for offline builds to work (I'm not a javascript toolchain expert, so I'm not fully sure why) puts a bit of a block on the ability to build from source.

That said, since both arm64 and amd64 packages are being shipped, any arm64 users using Flatpak won't be affected by this change.

If this Flatpak were to be verified by one of you folks upstream @Alipoodle (see: https://docs.flathub.org/docs/for-app-authors/verification) automerging updates could also be configured, which would improve how easily it is to maintain this repository.

I go into some more detail about the changes required here: #4

@ProjectSynchro
Copy link
Contributor Author

This is implemented now as of #4 being merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants