Unable to send signals from a D-Bus service I own #2770
Comments
This makes the Flatpak application self-contained from a thumbnail perspective, as it was already from a configuration perspective. Since thumbnails are no longer searched in `~/.cache` but in `$XDG_CACHE_HOME`, and the thumbnailing service name must be configurable at build time, Ristretto 0.12.2 is needed for this to work properly. Changes commited upstream in: https://gitlab.xfce.org/xfce/tumbler/-/commit/b075248d977a6491a6f0f63f5bc67cdb16c3a0f8 https://gitlab.xfce.org/xfce/tumbler/-/commit/7c7bd60f329e351ebdc02c5268364539d8197d29 A patch has also been added temporarily to Ristretto to overcome a problem of signal emission from Tumbler. See the message of this patch and: flathub/flathub#2770 flathub#7
This makes the Flatpak application self-contained from a thumbnail perspective, as it was already from a configuration perspective. Since thumbnails are no longer searched in `~/.cache` but in `$XDG_CACHE_HOME`, and the thumbnailing service name must be configurable at build time, Ristretto 0.12.2 is needed for this to work properly. Changes commited upstream in: https://gitlab.xfce.org/xfce/tumbler/-/commit/b075248d977a6491a6f0f63f5bc67cdb16c3a0f8 https://gitlab.xfce.org/xfce/tumbler/-/commit/7c7bd60f329e351ebdc02c5268364539d8197d29 A patch has also been added temporarily to Ristretto to overcome a problem of signal emission from Tumbler. See the message of this patch and: flathub/flathub#2770 #7
|
Please don't add The infra issue that caused said build failure has been fixed with flathub/org.flatpak.Builder#70. As you now bundled Tumbler, is there anything actionable left? |
This is the only real solution I have found so far. Since I couldn't get it to build on Flathub, I had to patch Ristretto itself in the meantime, to make up for Tumbler's inability to emit signals. But that's just temporary. The real solution would be to find the appropriate permissions for Tumbler, or to fix the bug on the Flatpak side if there is one. Because I don't see why a service owned by the main application (here Ristretto) should need special permissions to emit signals. If it's possible to set |
|
Indeed, it builds correctly with |
|
@barthalion @bilelmoussaoui If you don't have a better suggestion, I would be for merging flathub/org.xfce.ristretto#13: it will always be better than a (rough) patch on the main application. EDIT: merged :) |
|
What breaks from the UX perspective? |
|
What breaks is thumbnail display (View -> Show Thumbnail Bar). pkill tumblerd
rm -r ~/.var/app/org.xfce.ristretto/cache/thumbnails/*
/usr/bin/flatpak run --log-session-bus --branch=master --arch=x86_64 --command=/app/lib/tumbler-1/tumblerd org.xfce.ristrettoYou will get some of these errors when you launch Ristretto, and then you will get more if you scroll the thumbnail bar. Of course you need to open a directory with enough images: flatpak run org.xfce.ristretto ~/Images |
|
Hmm, this looks like flatpak/xdg-dbus-proxy#25 indeed. |
|
@gasinvein So do you think that Ristretto could be added to the list of exceptions in #2785 until this problem is solved? |
|
It's not my call, but I personally believe this is not strong enough reason to make an exception and create a precedent. |
|
I understand but then I don't see how I can unblock the situation for updates to Ristretto or its dependencies, as in flathub/org.xfce.ristretto#38. I really don't see myself tinkering with a patch on the main app to fill the lack of a proper IPC between Ristretto and its thumbnailer So I guess it will stay stuck in its current state for lack of anything better. |
|
@Tamaranch Please add your ID to https://github.com/flathub/flatpak-builder-lint/blob/master/flatpak_builder_lint/staticfiles/exceptions.json and open a PR. |
|
I can't reproduce the problem using: I don't think that we should add exception to D-Bus access checks unless the app is explicitly a D-Bus debugging tool. |
|
Removing permissions via |
|
Seems solved by having an exception for org.xfce.ristretto |
Maybe related to flatpak/xdg-dbus-proxy#25.
It works with
--socket=session-bus, but I don't know what permission to add besides that to make it work. Normally there should be no need for anything since the service name derives from my application name:org.xfce.ristretto->org.xfce.ristretto.Thumbnailer1.But I can't update my application with
--socket=session-bus: flathub/org.xfce.ristretto#7Here is an extract of the logs when running with
--log-session-bus:The text was updated successfully, but these errors were encountered: