Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitOps best practice repo to remove teams #18692

Closed
getvictor opened this issue May 1, 2024 · 2 comments
Closed

Update GitOps best practice repo to remove teams #18692

getvictor opened this issue May 1, 2024 · 2 comments
Assignees
@getvictor
Labels
~backend Backend-related issue. ~dogfood Issue resulted from Fleet's product dogfooding. #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook.
Milestone
4.51.0

Comments

@getvictor
Copy link
Member

getvictor commented May 1, 2024 •
edited
Loading

After #16677 (GitOps remove teams) is released to production, update GitOps best practice repo to use the new switches and delete non-configured teams.

QA

Make sure gitops has run on Dogfood successfully. See GitHub Actions.
@getvictor getvictor added #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook. ~backend Backend-related issue. labels May 1, 2024
@getvictor getvictor self-assigned this May 1, 2024
This was referenced May 1, 2024
Merged
Closed
getvictor added a commit that referenced this issue May 3, 2024
@getvictor
GitOps remove teams (#18640)
4f4800b 
#16677 

Improvements to `fleetctl gitops` command:
- Added the ability to pass multiple files, like `fleetctl gitops -f
file1 -f file2`, where the first file must be the global configuration
- Added the ability to remove teams that were not specified in team
configs using the switch `--delete-other-teams`
- When passing a global config and team config during initial
configuration, the `org_settings.mdm.apple_bm_default_team` value can be
set to match the team that will be created by the provided team config.

After these changes are released to prod, we can update
https://github.com/fleetdm/fleet-gitops to use the new switches: #18692

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
@getvictor getvictor changed the title Update GitOps best practice repo to remove teams [WAITING for 4.50 release] Update GitOps best practice repo to remove teams May 6, 2024
@getvictor getvictor changed the title [WAITING for 4.50 release] Update GitOps best practice repo to remove teams [WAITING for 4.50.0 release] Update GitOps best practice repo to remove teams May 6, 2024
@lukeheath lukeheath added this to the 4.51.0-tentative milestone May 13, 2024
@getvictor getvictor changed the title [WAITING for 4.50.0 release] Update GitOps best practice repo to remove teams Update GitOps best practice repo to remove teams May 24, 2024
@getvictor
Copy link
Member Author

PR for review: fleetdm/fleet-gitops#37

@getvictor getvictor added the ~dogfood Issue resulted from Fleet's product dogfooding. label May 29, 2024
@fleet-release
Copy link
Contributor

GitOps repo refined,
Teams removed, switch design shines,
Clear path users find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@getvictor getvictor

Labels
~backend Backend-related issue. ~dogfood Issue resulted from Fleet's product dogfooding. #g-endpoint-ops Endpoint ops product group :release Ready to write code. Scheduled in a release. See "Making changes" in handbook.
Projects
None yet
Milestone
4.51.0
Development

No branches or pull requests
3 participants
@lukeheath @getvictor @fleet-release