Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit App Store (VPP) app's targets: cancel pending installs/uninstalls #25912

Open
25 tasks
noahtalerman opened this issue Jan 30, 2025 · 1 comment
Open
25 tasks
Labels
#g-software Software product group story A user story defining an entire feature

Comments

@noahtalerman
Copy link
Member

noahtalerman commented Jan 30, 2025

Goal

User story
As an IT admin editing an App Store app's custom targets (scope),
I want Fleet to cancel all pending installs and uninstalls
so that I can be sure the app won't be installed or uninstalled on hosts outside of my new scope.

Key result

Auto-update (patch) any software without writing custom policies

Original requests

No original request. Created this story when we cut this from #24609

Context

Changes

Product

  • UI changes: Figma here
  • CLI (fleetctl) usage changes: No changes.
  • YAML changes: No changes.
  • REST API changes: No changes.
  • Fleet's agent (fleetd) changes: No changes.
  • Activity changes: No changes.
  • Permissions changes: No changes.
  • Changes to paid features or tiers: Fleet Premium
  • Transparency changes: No changes.
  • First draft of test plan added
  • Other reference documentation changes: No changes.
  • Once shipped, requester has been notified
  • Once shipped, dogfooding issue has been filed

Engineering

  • Test plan is finalized
  • Feature guide changes: TODO
  • Database schema migrations: TODO
  • Load testing: TODO

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

  • Requires load testing: TODO
  • Risk level: Low / High TODO
  • Risk description: TODO

Test plan

  • Add an App Store app, trigger an installation and uninstallation on several hosts, head to the Software title page, and verify that the "Pending" count is accurate.
  • Select Actions > Edit and change the software's targets. Select Save.
    • Verify that pending installs and uninstalls are canceled for hosts that are outside of the new target.
    • Verify that the "Pending" count is updated (likely smaller) to reflect that pending installs and uninstalls were canceled.
    • Verify that the the activities in Host details > Activity > Pending for hosts outside of the new target are removed, and that the software is never installed.
    • Verify that, for automatic installs, the policy that triggers the automatic install is reset for hosts that come in to the new scope. The policy status is not reset for hosts that were in the old scope and are still in the new scope.

Testing notes

Confirmation

  1. Engineer: Added comment to user story confirming successful completion of test plan.
  2. QA: Added comment to user story confirming successful completion of test plan.
@noahtalerman noahtalerman added #g-software Software product group :product Product Design department (shows up on 🦢 Drafting board) story A user story defining an entire feature labels Jan 30, 2025
@noahtalerman noahtalerman self-assigned this Jan 30, 2025
@noahtalerman noahtalerman changed the title Edit App Store (VPP) app's targets: cancel pending installs Edit App Store (VPP) app's targets: cancel pending installs/uninstalls Feb 3, 2025
@noahtalerman
Copy link
Member Author

During user story review on 2025-02-06 (Gong recording here - start at minute 35) we realized that if we want to cancel all pending installs/uninstalls for App Store apps, we'll have to handle license assignment and revocation which is tricky and bug prone.

Since this user story is a lower priority improvement I think we can deprioritize it. Fleet might come back to it so that the behavior for editing all software's target is the same: cancel pending installs/uninstalls.

Currently, for App Store apps, Fleet does not cancel pending installs/uninstalls. We tell the user this:

Image

Currently, for all other software, Fleet cancels pending installs/uninstalls. We tell the user this:

Image

cc @eugkuo @iansltx @jmwatts @mostlikelee

@noahtalerman noahtalerman removed their assignment Feb 12, 2025
@noahtalerman noahtalerman removed the :product Product Design department (shows up on 🦢 Drafting board) label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#g-software Software product group story A user story defining an entire feature
Projects
None yet
Development

No branches or pull requests

1 participant