Skip to content

Commit 09bfc5b

Browse files
weiliangjin2021weiliangjin2021
committed
refactor(rf): edge singularity correction defaults to True
BREAKING CHANGE: default value modified
1 parent ded37cd commit 09bfc5b

File tree

6 files changed

+26
-25
lines changed

6 files changed

+26
-25
lines changed

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3838
- Unified run submission API: `web.run(...)` is now a container-aware wrapper that accepts a single simulation or arbitrarily nested containers (`list`, `tuple`, `dict` values) and returns results in the same shape.
3939
- `web.Batch(ComponentModeler)` and `web.Job(ComponentModeler)` native support
4040
- Simulation data of batch jobs are now automatically downloaded upon their individual completion in `Batch.run()`, avoiding waiting for the entire batch to reach completion.
41+
- Edge singularity correction at PEC and lossy metal edges defaults to `True`.
4142

4243
### Fixed
4344
- More robust `Sellmeier` and `Debye` material model, and prevent very large pole parameters in `PoleResidue` material model.

‎schemas/EMESimulation.json‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8768,7 +8768,7 @@
87688768
"type": "object"
87698769
},
87708770
"edge_singularity_correction": {
8771-
"default": false,
8771+
"default": true,
87728772
"type": "boolean"
87738773
},
87748774
"timestep_reduction": {
@@ -11246,7 +11246,7 @@
1124611246
"lossy_metal": {
1124711247
"default": {
1124811248
"attrs": {},
11249-
"edge_singularity_correction": false,
11249+
"edge_singularity_correction": true,
1125011250
"timestep_reduction": 0.0,
1125111251
"type": "SurfaceImpedance"
1125211252
},
@@ -11294,7 +11294,7 @@
1129411294
"pec": {
1129511295
"default": {
1129611296
"attrs": {},
11297-
"edge_singularity_correction": false,
11297+
"edge_singularity_correction": true,
1129811298
"timestep_reduction": 0.3,
1129911299
"type": "PECConformal"
1130011300
},
@@ -11357,7 +11357,7 @@
1135711357
"type": "object"
1135811358
},
1135911359
"edge_singularity_correction": {
11360-
"default": false,
11360+
"default": true,
1136111361
"type": "boolean"
1136211362
},
1136311363
"timestep_reduction": {
@@ -12507,7 +12507,7 @@
1250712507
},
1250812508
"lossy_metal": {
1250912509
"attrs": {},
12510-
"edge_singularity_correction": false,
12510+
"edge_singularity_correction": true,
1251112511
"timestep_reduction": 0.0,
1251212512
"type": "SurfaceImpedance"
1251312513
},
@@ -12517,7 +12517,7 @@
1251712517
},
1251812518
"pec": {
1251912519
"attrs": {},
12520-
"edge_singularity_correction": false,
12520+
"edge_singularity_correction": true,
1252112521
"timestep_reduction": 0.3,
1252212522
"type": "PECConformal"
1252312523
},

‎schemas/ModeSimulation.json‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8422,7 +8422,7 @@
84228422
"type": "object"
84238423
},
84248424
"edge_singularity_correction": {
8425-
"default": false,
8425+
"default": true,
84268426
"type": "boolean"
84278427
},
84288428
"timestep_reduction": {
@@ -10922,7 +10922,7 @@
1092210922
"lossy_metal": {
1092310923
"default": {
1092410924
"attrs": {},
10925-
"edge_singularity_correction": false,
10925+
"edge_singularity_correction": true,
1092610926
"timestep_reduction": 0.0,
1092710927
"type": "SurfaceImpedance"
1092810928
},
@@ -10970,7 +10970,7 @@
1097010970
"pec": {
1097110971
"default": {
1097210972
"attrs": {},
10973-
"edge_singularity_correction": false,
10973+
"edge_singularity_correction": true,
1097410974
"timestep_reduction": 0.3,
1097510975
"type": "PECConformal"
1097610976
},
@@ -11033,7 +11033,7 @@
1103311033
"type": "object"
1103411034
},
1103511035
"edge_singularity_correction": {
11036-
"default": false,
11036+
"default": true,
1103711037
"type": "boolean"
1103811038
},
1103911039
"timestep_reduction": {
@@ -12297,7 +12297,7 @@
1229712297
},
1229812298
"lossy_metal": {
1229912299
"attrs": {},
12300-
"edge_singularity_correction": false,
12300+
"edge_singularity_correction": true,
1230112301
"timestep_reduction": 0.0,
1230212302
"type": "SurfaceImpedance"
1230312303
},
@@ -12307,7 +12307,7 @@
1230712307
},
1230812308
"pec": {
1230912309
"attrs": {},
12310-
"edge_singularity_correction": false,
12310+
"edge_singularity_correction": true,
1231112311
"timestep_reduction": 0.3,
1231212312
"type": "PECConformal"
1231312313
},

‎schemas/Simulation.json‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12388,7 +12388,7 @@
1238812388
"type": "object"
1238912389
},
1239012390
"edge_singularity_correction": {
12391-
"default": false,
12391+
"default": true,
1239212392
"type": "boolean"
1239312393
},
1239412394
"timestep_reduction": {
@@ -15248,7 +15248,7 @@
1524815248
"lossy_metal": {
1524915249
"default": {
1525015250
"attrs": {},
15251-
"edge_singularity_correction": false,
15251+
"edge_singularity_correction": true,
1525215252
"timestep_reduction": 0.0,
1525315253
"type": "SurfaceImpedance"
1525415254
},
@@ -15296,7 +15296,7 @@
1529615296
"pec": {
1529715297
"default": {
1529815298
"attrs": {},
15299-
"edge_singularity_correction": false,
15299+
"edge_singularity_correction": true,
1530015300
"timestep_reduction": 0.3,
1530115301
"type": "PECConformal"
1530215302
},
@@ -15359,7 +15359,7 @@
1535915359
"type": "object"
1536015360
},
1536115361
"edge_singularity_correction": {
15362-
"default": false,
15362+
"default": true,
1536315363
"type": "boolean"
1536415364
},
1536515365
"timestep_reduction": {
@@ -17016,7 +17016,7 @@
1701617016
},
1701717017
"lossy_metal": {
1701817018
"attrs": {},
17019-
"edge_singularity_correction": false,
17019+
"edge_singularity_correction": true,
1702017020
"timestep_reduction": 0.0,
1702117021
"type": "SurfaceImpedance"
1702217022
},
@@ -17026,7 +17026,7 @@
1702617026
},
1702717027
"pec": {
1702817028
"attrs": {},
17029-
"edge_singularity_correction": false,
17029+
"edge_singularity_correction": true,
1703017030
"timestep_reduction": 0.3,
1703117031
"type": "PECConformal"
1703217032
},

‎schemas/TerminalComponentModeler.json‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13082,7 +13082,7 @@
1308213082
"type": "object"
1308313083
},
1308413084
"edge_singularity_correction": {
13085-
"default": false,
13085+
"default": true,
1308613086
"type": "boolean"
1308713087
},
1308813088
"timestep_reduction": {
@@ -15928,7 +15928,7 @@
1592815928
},
1592915929
"lossy_metal": {
1593015930
"attrs": {},
15931-
"edge_singularity_correction": false,
15931+
"edge_singularity_correction": true,
1593215932
"timestep_reduction": 0.0,
1593315933
"type": "SurfaceImpedance"
1593415934
},
@@ -15938,7 +15938,7 @@
1593815938
},
1593915939
"pec": {
1594015940
"attrs": {},
15941-
"edge_singularity_correction": false,
15941+
"edge_singularity_correction": true,
1594215942
"timestep_reduction": 0.3,
1594315943
"type": "PECConformal"
1594415944
},
@@ -16684,7 +16684,7 @@
1668416684
"lossy_metal": {
1668516685
"default": {
1668616686
"attrs": {},
16687-
"edge_singularity_correction": false,
16687+
"edge_singularity_correction": true,
1668816688
"timestep_reduction": 0.0,
1668916689
"type": "SurfaceImpedance"
1669016690
},
@@ -16732,7 +16732,7 @@
1673216732
"pec": {
1673316733
"default": {
1673416734
"attrs": {},
16735-
"edge_singularity_correction": false,
16735+
"edge_singularity_correction": true,
1673616736
"timestep_reduction": 0.3,
1673716737
"type": "PECConformal"
1673816738
},
@@ -16795,7 +16795,7 @@
1679516795
"type": "object"
1679616796
},
1679716797
"edge_singularity_correction": {
16798-
"default": false,
16798+
"default": true,
1679916799
"type": "boolean"
1680016800
},
1680116801
"timestep_reduction": {

‎tidy3d/components/subpixel_spec.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ class PECConformal(AbstractSubpixelAveragingMethod):
121121
)
122122

123123
edge_singularity_correction: bool = pd.Field(
124-
False,
124+
True,
125125
title="Apply Singularity Model At Metal Edges",
126126
description="Apply field correction model at metallic edges where field singularity occurs. "
127127
"The edges should be straight, and aligned with the primal grids; and the wedge angle is either "

0 commit comments

Comments
 (0)