feat(tidy3d): FXC-3958-mypy-implement-type-defs-in-config-material-library-and-geometry

Author: marcorudolphflex

pyproject.toml

@@ -319,6 +319,9 @@ python_files = "*.py"
 python_version = "3.10"
 files = [
   "tidy3d/web",
+  "tidy3d/config",
+  "tidy3d/material_library",
+  "tidy3d/components/geometry"
 ]
 ignore_missing_imports = true
 follow_imports = "skip"

tidy3d/components/geometry/base.py

@@ -3,7 +3,7 @@
 from __future__ import annotations
 
 from abc import ABC
-from typing import Any, Callable, Literal, Optional, Union
+from typing import TYPE_CHECKING, Any, Callable, Literal, Optional, Union
 
 import numpy as np
 import pydantic.v1 as pydantic
@@ -21,6 +21,9 @@
 
 from . import base
 
+if TYPE_CHECKING:
+    from trimesh import Trimesh
+
 AREA_SIZE_THRESHOLD = 1e-36
 
 
@@ -44,7 +47,7 @@ class TriangleMesh(base.Geometry, ABC):
 
     @pydantic.root_validator(pre=True)
     @verify_packages_import(["trimesh"])
-    def _validate_trimesh_library(cls, values):
+    def _validate_trimesh_library(cls, values: dict[str, Any]) -> dict[str, Any]:
         """Check if the trimesh package is imported as a validator."""
         return values
 
@@ -303,7 +306,7 @@ def from_vertices_faces(cls, vertices: np.ndarray, faces: np.ndarray) -> Triangl
     @verify_packages_import(["trimesh"])
     def _triangles_to_trimesh(
         cls, triangles: np.ndarray
-    ):  # -> TrimeshType: We need to get this out of the classes and into functional methods operating on a class (maybe still referenced to the class)
+    ) -> Trimesh:  # -> We need to get this out of the classes and into functional methods operating on a class (maybe still referenced to the class)
         """Convert an (N, 3, 3) numpy array of triangles to a ``trimesh.Trimesh``."""
         import trimesh
 
@@ -492,7 +495,7 @@ def from_height_function(
     @verify_packages_import(["trimesh"])
     def trimesh(
         self,
-    ):  # -> TrimeshType: We need to get this out of the classes and into functional methods operating on a class (maybe still referenced to the class)
+    ) -> Trimesh:  # -> We need to get this out of the classes and into functional methods operating on a class (maybe still referenced to the class)
         """A ``trimesh.Trimesh`` object representing the custom surface mesh geometry."""
         return self._triangles_to_trimesh(self.triangles)