ci: pr-requirements-tests only on PR events (#2656)

* ci: pr-requirements-tests only on PR events

* more standard naming

* what's wrong on schema develop check

* a

* Why doesn't it see develop branch

* pr

* why not diffing

* Remove precommit

Author: daquinteroflex

.github/workflows/tidy3d-python-client-tests.yml

@@ -150,10 +150,10 @@ jobs:
         with:
           path: 'pr' 
 
-      - name: checkou-develop-branch
+      - name: checkout-develop-branch
         uses: actions/checkout@v4
         with:
-          ref: 'develop' 
+          ref: develop 
           path: 'develop' 
 
       - name: install-depedencies
@@ -187,7 +187,8 @@ jobs:
           # Use git diff to compare the two directories and get a list of changes
           # The command exits with 0 if no changes, 1 if changes are found.
           # We use '|| true' to prevent the workflow from stopping here on failure.
-          diff_output=$(git diff --no-index --name-status ./develop/tidy3d/schemas ./pr/tidy3d/schemas || true)
+          cd $GITHUB_WORKSPACE/develop
+          diff_output=$(git diff --no-index --name-status $GITHUB_WORKSPACE/develop/schemas $GITHUB_WORKSPACE/pr/schemas || true)
 
           # Check if there are any changes
           if [ -z "$diff_output" ]; then
@@ -234,7 +235,7 @@ jobs:
     # Run on open PRs OR when manually triggered with local_tests=true
     needs: determine-test-scope
     if: needs.determine-test-scope.outputs.local_tests == 'true'
-    name: Python ${{ matrix.python-version }} - self-hosted-runner 
+    name: python-${{ matrix.python-version }}-self-hosted-runner 
     runs-on: [ slurm-runner, 4xcpu ]
     container: 
       image: ghcr.io/astral-sh/uv:debian
@@ -258,7 +259,7 @@ jobs:
         fetch-depth: 0 # Required 0 for diff report.
         submodules: false
 
-    - name: Install project
+    - name: install-project
       env:
         PYTHON_VERSION: ${{ matrix.python-version }}
       run: |
@@ -279,7 +280,7 @@ jobs:
         echo "Testing vtk is correctly installed."
         python -c "import vtk"
 
-    - name: Run tests with coverage
+    - name: run-tests-coverage
       env:
         PYTHONUNBUFFERED: "1"
       run: |
@@ -292,7 +293,7 @@ jobs:
         echo "total=$TOTAL_COVERAGE" >> "$GITHUB_ENV"
         echo "### Total coverage: ${TOTAL_COVERAGE}%"
 
-    - name: Produce the diff coverage report
+    - name: diff-coverage-report
       if: >- 
         matrix.python-version == '3.13' &&
         github.event_name == 'pull_request' &&
@@ -343,7 +344,7 @@ jobs:
     # Run tests on a push event OR a workflow dispatch with remote_tests
     needs: determine-test-scope
     if: needs.determine-test-scope.outputs.remote_tests == 'true'
-    name: Python ${{ matrix.python-version }} - ${{ matrix.platform }}
+    name: python-${{ matrix.python-version }}-${{ matrix.platform }}
     runs-on: ${{ matrix.platform }}
     permissions:
       contents: read
@@ -369,19 +370,19 @@ jobs:
         fetch-depth: 1
         submodules: false
 
-    - name: Install Poetry
+    - name: install-poetry
       uses: snok/install-poetry@v1
       with:
         version: 2.1.1
         virtualenvs-create: true
         virtualenvs-in-project: true
 
-    - name: Set up Python ${{ matrix.python-version }}
+    - name: set-python-${{ matrix.python-version }}
       uses: actions/setup-python@v4
       with:
         python-version: ${{ matrix.python-version }}
 
-    - name: Install project
+    - name: install-project
       run: |
         poetry --version
         poetry env use python
@@ -390,11 +391,11 @@ jobs:
         poetry run pip install gdstk --only-binary gdstk
         poetry install -E dev
 
-    - name: Run doctests
+    - name: run-doctests
       run: |
         poetry run pytest -rF --tb=short tidy3d
 
-    - name: Run tests with coverage
+    - name: run-tests-coverage
       env:
         PYTHONUNBUFFERED: "1"
       run: |
@@ -405,7 +406,7 @@ jobs:
         echo "total=$TOTAL_COVERAGE" >> "$GITHUB_ENV"
         echo "### Total coverage: ${TOTAL_COVERAGE}%"
 
-    - name: "Create badge"
+    - name: create-badge
       if: ${{ github.ref == 'refs/heads/develop' }}
       # https://gist.githubusercontent.com/nedbat/8c6980f77988a327348f9b02bbaf67f5
       uses: schneegans/[email protected]
@@ -423,10 +424,11 @@ jobs:
   pr-requirements-pass:
     name: pr-requirements-pass
     if: |
-      always() && 
-      ( needs.determine-test-scope.outputs.pr_approval_state == 'true' ) && 
+      always() &&
+      ((github.event_name == 'pull_request') || (github.event_name == 'pull_request_review'))  && 
+      (( needs.determine-test-scope.outputs.pr_approval_state == 'true' ) && 
       ( needs.determine-test-scope.outputs.local_tests == 'true' ) || 
-      ( needs.determine-test-scope.outputs.remote_tests == 'true' )
+      ( needs.determine-test-scope.outputs.remote_tests == 'true' ))
     needs: [local-tests, remote-tests, lint, verify-schema-change]
     runs-on: ubuntu-latest
     steps:

.pre-commit-config.yaml

@@ -6,11 +6,3 @@ repos:
        args: [ --fix ]
      - id: ruff-format
 
-  - repo: local
-    hooks:
-      - id: regenerate-schema
-        name: regenerate-schema
-        entry: python scripts/regenerate_schema.py
-        language: system
-        files: ^tidy3d/.*\.py$  # Run only when Python files in the core 'tidy3d' directory are modified.
-        stages: [pre-commit] # Explicitly run during the commit stage.