Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not receiving activesupport notifications under 1.3.1 #886

Open
iftheshoefritz opened this issue Sep 27, 2024 · 1 comment
Open

Not receiving activesupport notifications under 1.3.1 #886

iftheshoefritz opened this issue Sep 27, 2024 · 1 comment

Comments

@iftheshoefritz
Copy link

iftheshoefritz commented Sep 27, 2024

We upgraded from 1.1.2 to 1.3.1 and found that we no longer get activesupport notifications with this line in an initializer:

ActiveSupport::Notifications.subscribe("feature_operation.flipper") do
   # block was being called in 1.1.2 but not in 1.3.1
end

What might have changed?

@thomas-tz
Copy link

thomas-tz commented Oct 24, 2024

EDIT: I wrote this with the assumption that this was in a failing test, but if this is while running in dev/test/prod then that's completely different

It's probably because of test_help.rb in https://github.com/flippercloud/flipper/blob/main/lib/flipper/test_help.rb.

It doesn't pass any options for the instrumenter (usually active support notifications by default if you're using rails) to the flipper initialize method and it defaults to a "noop" instrumenter over here https://github.com/flippercloud/flipper/blob/main/lib/flipper/dsl.rb, which I believe doesn't do anything?

It would be nice if it was possible to have it respect the instrumenter in the test help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants