-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instructions in "Setting up a dev environment" are not working #1284
Comments
Yes I already spoke about that with the dev, but for an older version. But the error you have doesnt look like those I had at the time... Could you try something and tell me if it works ? First, try using Node 14.17.0. If it doesn't work, check this discussion for more steps from the creator. If you get it to work, tell me also if using Node 14.17 was enough, or if you had to do something else that you read in the discussion I provided above (or something else you found online). It would help me for writing the new steps on the README.md. |
With node 14 there's an issue with package-lock versions. npm bundled with node 14 still uses package-lock version 1, node 16 switched to version 2, and the current
And that leads to some follow-up errors down the road. After some tests, this is what worked in the end on a freshly cloned repo:
But I don't think that this is a sustainable solution because node 14 will be EOL after April 2023 - see https://github.com/nodejs/release#release-schedule Even node 16 will only be maintained until September 2023 - https://nodejs.org/en/blog/announcements/nodejs16-eol/ Something needs to be done to make this project work with the current node LTS version (18 at the moment). |
Remove dependency "fibers", which does not work with node 16 and above - see https://github.com/laverdet/node-fibers#readme. Update instructions to setup development environment in README
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Which version of floccus are you using?
4.17.1
Sync method
Nextcloud Bookmarks
Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.
No response
Which version of Nextcloud Bookmarks are you using? (if relevant)
No response
Which version of Nextcloud? (if relevant)
No response
What kind of WebDAV server are you using? (if relevant)
No response
Describe the Bug
Following the instructions in Setting up a dev environment results in an error when running
gulp
:It appears to be this issue: laverdet/node-fibers#451
Apparently, fibers is not compatible with node v16 or higher. See also https://github.com/laverdet/node-fibers#readme
Expected Behavior
Running
gulp
should succeed.To Reproduce
Debug log provided
The text was updated successfully, but these errors were encountered: