Support Node v18 for build #1285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove dependency "fibers", which does not work with node 16 and above - see https://github.com/laverdet/node-fibers#readme. Update instructions to setup development environment in README
marcelklehr
reviewed
Nov 13, 2022
| - In the root of your floccus repo, run `npm install && npm install -g gulp` | ||
| - Run `gulp` to build | ||
| - Find out more on how to develop browser extensions here: <https://extensionworkshop.com/> | ||
| - Install the [latest LTS version of node.js](https://nodejs.org/en/download/). |
There was a problem hiding this comment.
Can we just update this to v18 instead of the generic "latest lts"?
There was a problem hiding this comment.
My idea was: with "latest LTS" one does not have to update the README again when switching from v18 to v20.
And I thought it makes sense to keep the project aligned with the current active LTS version of nodejs.
There was a problem hiding this comment.
BTW, should the actions in .github/workflows/ be updated to use node v18?
heapifyman
deleted the
fix/1284-instructions-in-setting-up-a-dev-environment-are-not-working
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1284
Remove dependency "fibers", which does not work with node 16 and above - see https://github.com/laverdet/node-fibers#readme.
Disable use of "fibers" in "sass-loader" according to https://webpack.js.org/loaders/sass-loader/#string.
Update instructions to setup development environment in README. It should be possible to build the project with nodejs 18 (current LTS version) now.
I've tried
npm run buildandnpm run watch, and both succeeded with out errors. I haven't tried actually running the project in Android Studio, for example.