Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cards not working/showing using pt-BR language #51

Open
danielvetromilla opened this issue Jun 10, 2016 · 2 comments
Open

Some cards not working/showing using pt-BR language #51

danielvetromilla opened this issue Jun 10, 2016 · 2 comments
Labels

Comments

@danielvetromilla
Copy link

danielvetromilla commented Jun 10, 2016

Cards with ID ending with "e" letter (e.g. Card ID: EX1_128e) displays a black card image with no information at all.

Take this example: [Ocultar]

It will display this broken image:

Card ID 128e

But if i remove the "e" letter from its ID, it shows correctly:

Card ID 128

This issue was tested using pt-BR language.

@danielvetromilla
Copy link
Author

To temporary workaround this in my website, i've added a small regex replace to remove the last ocurrence of "e" letter in card id string.

- hearthstone-cards/public/assets/js/public.js
var card_id = $( this ).data( "hcfw-card-id" ).replace(/e$/, '');

@flowdee
Copy link
Owner

flowdee commented Jun 11, 2016

#50

@flowdee flowdee added the bug label Jun 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants