Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node-Flowdock doesn't work in Node 7 #30

Open
pimterry opened this issue Feb 10, 2017 · 0 comments
Open

Node-Flowdock doesn't work in Node 7 #30

pimterry opened this issue Feb 10, 2017 · 0 comments

Comments

@pimterry
Copy link

In Node 7, process.EventEmitter doesn't exist (and in Node 6 it's deprecated, and will print a warning), but Session here extends it. See nodejs/node#6862 for more details.

It'd be nice if the engines field in node-flowdock's package.json caught this, but it'd be even better if this worked. You could plausibly move to const EventEmitter = process.EventEmitter || require('events').EventEmitter if you want to keep backwards compatibility too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant