Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request For Comments] Should FL-LIB be imported in the project? #2

Open
flplv opened this issue Apr 19, 2017 · 2 comments
Open

[Request For Comments] Should FL-LIB be imported in the project? #2

flplv opened this issue Apr 19, 2017 · 2 comments

Comments

@flplv
Copy link
Owner

flplv commented Apr 19, 2017

Currently react.o has its own implementation and tests for linked lists, FIFOs and arrays.
These same storages have been copied to a new project called fl-lib, my own C and C++ library with reusable storages in a single header file.

There are improvements that must be done to some storages, linked list should be reimplemented to match Linus Torvalds suggestions, in instance. Every time we change the storages I'll have to edit two projects. Besides, its 2017 and I really wonder if we have to re-re-re-re-re-invent the wheel every time.

So, here comes the dilemma: Should we remove react.o's implementation of storages and import the fl-lib to the project?

Pros:
fl-lib is a storage library: tests will have more coverage and it will be used by more projects.
It's gonna be easier to maintain.

Cons:
We will add more name into the client namespace that are not reacto_ prefixed, fl-lib has fl_ prefix.
It's not that elegant in the beauty of coding standpoint to add this lib.

At the end, this decision is more taste related than technical related, that's why I can't decide by myself. I'm having hard time to choose beauty over maintainability or the other way around.

What do YOU choose?

@jknGH
Copy link

jknGH commented Apr 23, 2021

Hello Felipe - this is really an attempt to get in touch about reacto. I am thinking of implementing/using a reactive framework in a small embedded system and came across this work of yours. I'd be interested in its current state and what you have done with it since inception ;-). Your LinkedIn account listed via github doesn't seem to exist... Cheers from the UK, Jon N

@flplv
Copy link
Owner Author

flplv commented Apr 23, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants