Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Flaky 'does retries correctly when #try_write fails' test #4873

Closed
Watson1978 opened this issue Mar 19, 2025 · 0 comments · Fixed by #4877
Closed

CI: Flaky 'does retries correctly when #try_write fails' test #4873

Watson1978 opened this issue Mar 19, 2025 · 0 comments · Fixed by #4877
Labels
CI Test/CI issues

Comments

@Watson1978
Copy link
Contributor

Describe the bug

Sometimes, 'does retries correctly when #try_write fails' test fails on CI

fluentd/test/plugin/test_output_as_buffered_retries.rb

Line 915 in 8a4506b

test 'does retries correctly when #try_write fails' do 

1) Failure: test: does retries correctly when #try_write fails(BufferedOutputRetryTest::buffered output with delayed commit): <false> is not true.
/Users/runner/work/fluentd/fluentd/test/plugin/test_output_as_buffered_retries.rb:963:in `block (2 levels) in <class:BufferedOutputRetryTest>'
     960:       end
     961: 
     962:       assert(@i.write_count > 1)
  => 963:       assert(@i.num_errors > 1)
     964:     end
     965:   end
     966: end

To Reproduce

Run CI

Expected behavior

No error

Your Environment

- Fluentd version:
- Package version:
- Operating system:
- Kernel version:

Your Configuration

none

Your Error Log

See above

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI Test/CI issues
Projects
Fluentd Kanban
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test_output_as_buffered_retries: fix flaky test Watson1978/fluentd
1 participant
@Watson1978