refactor(app_review): simplify feedback model

- Rename InitialAppReviewFeedback to AppReviewFeedback
- Remove NegativeFeedback class and related history
- Replace with a single feedback field and optional feedbackDetails string
- Update related tests and fixtures

Author: fulleni

lib/src/enums/initial_app_review_feedback.dart renamed to lib/src/enums/app_review_feedback.dart

@@ -1,11 +1,11 @@
 import 'package:json_annotation/json_annotation.dart';
 
-/// {@template initial_app_review_feedback}
-/// Represents the user's response to the initial, private app review prompt
+/// {@template app_review_feedback}
+/// Represents the user's response to the private app review prompt
 /// (e.g., "Are you enjoying the app?").
 /// {@endtemplate}
 @JsonEnum()
-enum InitialAppReviewFeedback {
+enum AppReviewFeedback {
   /// The user indicated a positive experience.
   @JsonValue('positive')
   positive,

lib/src/enums/enums.dart

@@ -3,6 +3,7 @@ export 'ad_type.dart';
 export 'app_accent_theme.dart';
 export 'app_base_theme.dart';
 export 'app_font_weight.dart';
+export 'app_review_feedback.dart';
 export 'app_text_scale_factor.dart';
 export 'app_user_role.dart';
 export 'banner_ad_shape.dart';
@@ -20,7 +21,6 @@ export 'feed_item_click_behavior.dart';
 export 'feed_item_density.dart';
 export 'feed_item_image_style.dart';
 export 'headline_report_reason.dart';
-export 'initial_app_review_feedback.dart';
 export 'push_notification_provider.dart';
 export 'push_notification_subscription_delivery_type.dart';
 export 'reaction_type.dart';

lib/src/fixtures/app_reviews.dart

@@ -39,7 +39,7 @@ List<AppReview> getAppReviewsFixturesData({
         AppReview(
           id: 'ar-pos-$i',
           userId: user.id,
-          initialFeedback: InitialAppReviewFeedback.positive,
+          feedback: AppReviewFeedback.positive,
           createdAt: createdAt,
           updatedAt: createdAt.add(const Duration(minutes: 1)),
           wasStoreReviewRequested: true,
@@ -52,15 +52,10 @@ List<AppReview> getAppReviewsFixturesData({
         AppReview(
           id: 'ar-neg-reason-$i',
           userId: user.id,
-          initialFeedback: InitialAppReviewFeedback.negative,
+          feedback: AppReviewFeedback.negative,
           createdAt: createdAt,
           updatedAt: createdAt,
-          negativeFeedbackHistory: [
-            NegativeFeedback(
-              providedAt: createdAt,
-              reason: reasons[i % reasons.length],
-            ),
-          ],
+          feedbackDetails: reasons[i % reasons.length],
         ),
       );
     }
@@ -70,7 +65,7 @@ List<AppReview> getAppReviewsFixturesData({
         AppReview(
           id: 'ar-neg-$i',
           userId: user.id,
-          initialFeedback: InitialAppReviewFeedback.negative,
+          feedback: AppReviewFeedback.negative,
           createdAt: createdAt,
           updatedAt: createdAt,
         ),
@@ -90,7 +85,7 @@ List<AppReview> getAppReviewsFixturesData({
     AppReview(
       id: 'ar-multistage-final',
       userId: multiStageUser.id,
-      initialFeedback: InitialAppReviewFeedback.positive,
+      feedback: AppReviewFeedback.positive,
       // createdAt would be from the first interaction
       createdAt: firstReviewTime,
       // updatedAt is from the most recent interaction
@@ -99,9 +94,7 @@ List<AppReview> getAppReviewsFixturesData({
       // depending on business logic. Here we assume it's cleared on positive.
       wasStoreReviewRequested: true,
       // The history might be kept for analytics, even after a positive review.
-      negativeFeedbackHistory: [
-        NegativeFeedback(providedAt: firstReviewTime, reason: reasons[1]),
-      ],
+      feedbackDetails: reasons[1],
     ),
   );
 
@@ -113,13 +106,10 @@ List<AppReview> getAppReviewsFixturesData({
     AppReview(
       id: 'ar-multi-neg',
       userId: persistentNegativeUser.id,
-      initialFeedback: InitialAppReviewFeedback.negative,
+      feedback: AppReviewFeedback.negative,
       createdAt: firstNegativeTime,
       updatedAt: secondNegativeTime,
-      negativeFeedbackHistory: [
-        NegativeFeedback(providedAt: firstNegativeTime, reason: reasons[2]),
-        NegativeFeedback(providedAt: secondNegativeTime, reason: reasons[3]),
-      ],
+      feedbackDetails: reasons[3],
     ),
   );
 

lib/src/models/user_generated_content/app_review.dart

@@ -29,7 +29,7 @@ part 'app_review.g.dart';
 ///
 /// - **Layer 1 (Internal Prompt)**: A private, low-friction UI element within the
 ///   app gauges user sentiment (e.g., "Are you enjoying the app?"). This acts as
-///   a crucial filter. The user's response is captured in the [initialFeedback]
+///   a crucial filter. The user's response is captured in the [feedback]
 ///   field.
 ///
 /// - **Layer 2 (Native OS Prompt)**: Only if a user provides a positive signal in
@@ -46,11 +46,11 @@ class AppReview extends Equatable {
   const AppReview({
     required this.id,
     required this.userId,
-    required this.initialFeedback,
+    required this.feedback,
     required this.createdAt,
     required this.updatedAt,
-    this.negativeFeedbackHistory = const [],
     this.wasStoreReviewRequested = false,
+    this.feedbackDetails,
   });
 
   /// Creates an [AppReview] from JSON data.
@@ -63,8 +63,8 @@ class AppReview extends Equatable {
   /// The ID of the user providing the feedback.
   final String userId;
 
-  /// The user's answer to the initial, private feedback prompt.
-  final InitialAppReviewFeedback initialFeedback;
+  /// The user's answer to the private feedback prompt.
+  final AppReviewFeedback feedback;
 
   /// The timestamp when this review record was created (i.e., when the user
   /// answered the initial prompt).
@@ -78,19 +78,17 @@ class AppReview extends Equatable {
   /// A flag indicating whether a native OS store review has been requested for
   /// this user.
   ///
-  /// This is set to `true` after a user provides a `positive` [initialFeedback]
+  /// This is set to `true` after a user provides a `positive` [feedback]
   /// and the application calls the native review API. It acts as a permanent
   /// marker, ensuring the corresponding `UserFeedDecoratorStatus` can be marked
   /// as completed to prevent ever showing the internal prompt again.
   @JsonKey(defaultValue: false)
   final bool wasStoreReviewRequested;
 
-  /// A historical log of all negative feedback instances from the user.
+  /// Optional text details provided by the user, typically when giving
+  /// negative feedback.
   ///
-  /// Each time a user responds negatively to the initial prompt, a new
-  /// [NegativeFeedback] entry is added to this list. This preserves valuable
-  /// historical data on user sentiment.
-  final List<NegativeFeedback> negativeFeedbackHistory;
+  final String? feedbackDetails;
 
   /// Converts this [AppReview] instance to JSON data.
   Map<String, dynamic> toJson() => _$AppReviewToJson(this);
@@ -99,30 +97,29 @@ class AppReview extends Equatable {
   List<Object?> get props => [
     id,
     userId,
-    initialFeedback,
+    feedback,
     createdAt,
     updatedAt,
     wasStoreReviewRequested,
-    negativeFeedbackHistory,
+    feedbackDetails,
   ];
 
   /// Creates a copy of this [AppReview] with updated values.
   AppReview copyWith({
-    InitialAppReviewFeedback? initialFeedback,
+    AppReviewFeedback? feedback,
     DateTime? updatedAt,
     bool? wasStoreReviewRequested,
-    List<NegativeFeedback>? negativeFeedbackHistory,
+    String? feedbackDetails,
   }) {
     return AppReview(
       id: id,
       userId: userId,
-      initialFeedback: initialFeedback ?? this.initialFeedback,
+      feedback: feedback ?? this.feedback,
       createdAt: createdAt,
       updatedAt: updatedAt ?? this.updatedAt,
       wasStoreReviewRequested:
           wasStoreReviewRequested ?? this.wasStoreReviewRequested,
-      negativeFeedbackHistory:
-          negativeFeedbackHistory ?? this.negativeFeedbackHistory,
+      feedbackDetails: feedbackDetails ?? this.feedbackDetails,
     );
   }
 }

lib/src/models/user_generated_content/app_review.g.dart

@@ -1,6 +1,5 @@
 export 'app_review.dart';
 export 'comment.dart';
 export 'engagement.dart';
-export 'negative_feedback.dart';
 export 'reaction.dart';
 export 'report.dart';

lib/src/models/user_generated_content/negative_feedback.dart

@@ -0,0 +1,22 @@
+import 'package:core/src/enums/app_review_feedback.dart';
+import 'package:test/test.dart';
+
+void main() {
+  group('AppReviewFeedback', () {
+    test('has correct string names', () {
+      expect(AppReviewFeedback.positive.name, 'positive');
+      expect(AppReviewFeedback.negative.name, 'negative');
+    });
+
+    test('can be created from string names', () {
+      expect(
+        AppReviewFeedback.values.byName('positive'),
+        AppReviewFeedback.positive,
+      );
+      expect(
+        AppReviewFeedback.values.byName('negative'),
+        AppReviewFeedback.negative,
+      );
+    });
+  });
+}