diff --git a/third_party/src/main/java/com/jetbrains/lang/dart/ide/runner/DartExceptionBreakpointType.java b/third_party/src/main/java/com/jetbrains/lang/dart/ide/runner/DartExceptionBreakpointType.java index 7ad3cc753..6d1be0046 100644 --- a/third_party/src/main/java/com/jetbrains/lang/dart/ide/runner/DartExceptionBreakpointType.java +++ b/third_party/src/main/java/com/jetbrains/lang/dart/ide/runner/DartExceptionBreakpointType.java @@ -8,7 +8,7 @@ import com.intellij.xdebugger.breakpoints.XBreakpoint; import com.intellij.xdebugger.breakpoints.XBreakpointType; import com.intellij.xdebugger.breakpoints.ui.XBreakpointCustomPropertiesPanel; -import com.intellij.xdebugger.impl.breakpoints.XBreakpointBase; + import com.jetbrains.lang.dart.DartBundle; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; @@ -17,7 +17,7 @@ import java.awt.*; public final class DartExceptionBreakpointType - extends XBreakpointType, DartExceptionBreakpointProperties> { + extends XBreakpointType, DartExceptionBreakpointProperties> { public DartExceptionBreakpointType() { super("dart-exception", DartBundle.message("breakpoint.type.title.dart.exception.breakpoint")); @@ -49,19 +49,22 @@ public String getDisplayText(XBreakpoint brea } @Override - public XBreakpoint createDefaultBreakpoint(@NotNull XBreakpointCreator creator) { - final XBreakpoint breakpoint = creator.createBreakpoint(new DartExceptionBreakpointProperties()); + public XBreakpoint createDefaultBreakpoint( + @NotNull XBreakpointCreator creator) { + final XBreakpoint breakpoint = creator + .createBreakpoint(new DartExceptionBreakpointProperties()); breakpoint.setEnabled(true); return breakpoint; } @Override - public @Nullable XBreakpointCustomPropertiesPanel> createCustomPropertiesPanel(final @NotNull Project project) { + public @Nullable XBreakpointCustomPropertiesPanel> createCustomPropertiesPanel( + final @NotNull Project project) { return new DartExceptionBreakpointPropertiesPanel(); } private static class DartExceptionBreakpointPropertiesPanel - extends XBreakpointCustomPropertiesPanel> { + extends XBreakpointCustomPropertiesPanel> { private JBRadioButton myBreakOnUncaughtExceptions; private JBRadioButton myBreakOnAllExceptions; @@ -89,7 +92,9 @@ public void saveTo(final @NotNull XBreakpoint final boolean newValue = myBreakOnAllExceptions.isSelected(); if (oldValue != newValue) { breakpoint.getProperties().setBreakOnAllExceptions(newValue); - ((XBreakpointBase)breakpoint).fireBreakpointChanged(); + // 'fireBreakpointChanged' is an internal API. The platform handles change + // notifications + // automatically after 'saveTo' returns, so explicit firing is not needed. } } @@ -97,8 +102,7 @@ public void saveTo(final @NotNull XBreakpoint public void loadFrom(final @NotNull XBreakpoint breakpoint) { if (breakpoint.getProperties().isBreakOnAllExceptions()) { myBreakOnAllExceptions.setSelected(true); - } - else { + } else { myBreakOnUncaughtExceptions.setSelected(true); } }