Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it obvious when Flutter commands finish. #527

Closed
pq opened this issue Dec 12, 2016 · 4 comments · Fixed by #529
Closed

Make it obvious when Flutter commands finish. #527

pq opened this issue Dec 12, 2016 · 4 comments · Fixed by #529
Assignees
@pq
Labels
enhancement
Milestone
0.1.7

Comments

@pq
Copy link
Contributor

pq commented Dec 12, 2016

Following up from #525, we should make sure all commands display something on finish.
@pq pq added the enhancement label Dec 12, 2016
@pq pq self-assigned this Dec 12, 2016
@pq
Copy link
Contributor Author

pq commented Dec 12, 2016

(Got this.)

@devoncarew
Copy link
Member

FYI, the Dart plugin suffixes processes with Process finished with exit code 0.

@pq
Copy link
Contributor Author

pq commented Dec 12, 2016

Cool. I'm tempted to add this for all commands. (Unless you think otherwise?)

@devoncarew
Copy link
Member

Yeah, making it uniform sounds great.

pq added a commit to pq/flutter-intellij that referenced this issue Dec 12, 2016
@pq
Add console output on Flutter command completion (flutter#527).
9976a54 
Fixes: flutter#527.

* adds process termination console output
* fixes pubspec finding (when `CommonDataKeys.PSI_FILE` or `LangDataKeys.MODULE` cache-miss)
@pq pq mentioned this issue Dec 12, 2016
Merged
@pq pq closed this as completed in #529 Dec 12, 2016
pq added a commit that referenced this issue Dec 12, 2016
@pq
Add console output on Flutter command completion (#527). (#529)
9777186 
* Add console output on Flutter command completion (#527).

Fixes: #527.

* adds process termination console output
* fixes pubspec finding (when `CommonDataKeys.PSI_FILE` or `LangDataKeys.MODULE` cache-miss)

* Mutiple pubspec check.
@mit-mit mit-mit added this to the 0.1.7 milestone Dec 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
enhancement
Projects
None yet
Milestone
0.1.7
Development

Successfully merging a pull request may close this issue.

Add console output on Flutter command completion (#527). pq/flutter-intellij
3 participants
@pq @devoncarew @mit-mit