Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs aren't clickable in API docs when reading source code #804

Open
sethladd opened this issue Mar 10, 2017 · 6 comments
Open

URLs aren't clickable in API docs when reading source code #804

sethladd opened this issue Mar 10, 2017 · 6 comments
Labels
Milestone

Comments

@sethladd
Copy link

From a UX study.

It appears that "jump to definition" is really popular way to learn the system. Sometimes, we include URLs in the API docs (either to the website or the material site). It would be cool if the developer could just click those URLs and open a browser.

Workaround: copy the link out of the editor and paste into a browser window.

@pq
Copy link
Contributor

pq commented Mar 13, 2017

This should already work in regular source files.

ss

@sethladd can you point me to a link in a framework doc so I can confirm that it works there too?

@sethladd
Copy link
Author

Sure this. Check out material.dart:

screen shot 2017-03-13 at 9 48 59 am

We're (apparently) using Markdown syntax here. Maybe we should change that? But I think it's expected that this would work.

@pq
Copy link
Contributor

pq commented Mar 13, 2017

Interestingly, this works for me...

ss2

(Note that you need to hold down ⌘ while hovering... Maybe that's not obvious?)

@sethladd
Copy link
Author

Yeah, that's definitely not obvious :)

Can we auto-link these?

@pq
Copy link
Contributor

pq commented Mar 13, 2017

cc @alexander-doroshko for any ideas

@alexander-doroshko
Copy link
Contributor

I think it was done just like all other references in code. There's no special highlighting for references but you know that you can Cmd+Click or Cmd+B on it to jump to the declaration. The same was done for links in comments.

I think special highlighting for links in comments is discussable (not with me :) ). I even noticed that the IDE already has a color setting for it that is simply not used for this case (Settings | Editor | Colors & Fonts | General -> Hyperlinks).

Interesting that @sethladd wrote that "jump to definition is really popular" but didn't try it on a link. :)

@pq pq added from: study Reported in a UX study. and removed from study labels Mar 15, 2017
@pq pq added this to the Backlog milestone May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants